facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 14:28:17 +03:00
Code Issues Projects Releases Wiki Activity

buckify Windows build

Browse Source 
Summary:
Lately we have experienced some issues with the cargo version of our build due to some curl issues. D50680070 fixes the curl issues, but only on the buck side of things.

Since our Buck build on Windows is now mature enough and can solve our curl issue, let's switch to it.

Reviewed By: quark-zju

Differential Revision: D50704305

fbshipit-source-id: 9de86162fdbc6b97eeae074f1c0fbb2bab7ce1d6
This commit is contained in:
Saul Gutierrez 2023-10-27 14:45:13 -07:00 committed by Facebook GitHub Bot
parent 3b405e8772
commit 4ab483da0e
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
eden/scm/gen_version.py
View File

@ -22,6 +22,18 @@ def main() -> None:
ap.add_argument("output_path")
args = ap.parse_args()
# On POSIX single quotes are interpreted as empty strings, but on Windows
# they are interpreted as literal single quotes so we have to get rid of
# them. It's not possible to just use double quotes instead.
# On Buck this script is called with arguments like
# --version '%s' --release '%s' --revision '%s' <OUTPUT_PATH>
# It's not possible to change the single quotes with double ones, because
# otherwise buck interprets it as if we were empty and <OUTPUT_PATH> gets
# parsed as a value for revision
args.version = args.version.replace("'", "")
args.release = args.release.replace("'", "")
args.revision = args.revision.replace("'", "")
if args.version and args.release:
sub_version = "%s_%s_%s" % (args.version, args.release, args.revision[:8])
elif args.revision: