Default httpbookmarks to True

Summary:
## Context
See D33771940

## This diff
I move `pull.httpbookmarks` and `infinitepush.httpbookmarks` to True.

Reviewed By: quark-zju

Differential Revision: D33891956

fbshipit-source-id: cbc3d92aa7ac7ac9edf90b4f99ab9804e9d750be
This commit is contained in:
Yan Soares Couto 2022-02-02 07:20:53 -08:00 committed by Facebook GitHub Bot
parent d274a0f575
commit 4e25a7ef08
8 changed files with 10 additions and 18 deletions

View File

@ -8,7 +8,7 @@
$ configure modern
$ setconfig pull.master-fastpath=1 \
> remotenames.selectivepulldefault=master_bookmark \
> pull.httpcommitgraph=1 pull.httpbookmarks=1 pull.httphashprefix=1 \
> pull.httpcommitgraph=1 pull.httphashprefix=1 \
> exchange.httpcommitlookup=1
Set up local hgrc and Mononoke config, with http pull

View File

@ -48,7 +48,6 @@ Set up local hgrc and Mononoke config, with commit cloud, http pull and upload.
> reponame=repo
> [pull]
> httpcommitgraph = true
> httpbookmarks = true
> httphashprefix = true
> [exchange]
> httpcommitlookup = true

View File

@ -58,7 +58,6 @@ Do infinitepush (aka commit cloud) push
> [extensions]
> remotenames=
> [infinitepush]
> httpbookmarks=True
> server=False
> branchpattern=re:scratch/.+
> EOF

View File

@ -51,27 +51,27 @@ switch to client and enable infinitepush extension
$ setconfig extensions.infinitepush=
match with glob pattern
$ hgmn book --list-remote test/*
$ hgedenapi book --list-remote test/*
test/one 26805aba1e600a82e93661149f2313866a221a7b
test/three 051cf22dff5ca70a5ba3d06d1f9dd08407dfd1a6
test/two 4b61ff5c62e28cff36152201967390a6e7375604
match with literal pattern
$ hgmn book --list-remote test
$ hgmn book --list-remote test/three
$ hgedenapi book --list-remote test
$ hgedenapi book --list-remote test/three
test/three 051cf22dff5ca70a5ba3d06d1f9dd08407dfd1a6
$ hgmn book --list-remote test/t*
$ hgedenapi book --list-remote test/t*
test/three 051cf22dff5ca70a5ba3d06d1f9dd08407dfd1a6
test/two 4b61ff5c62e28cff36152201967390a6e7375604
match multiple patterns
$ hgmn book --list-remote test/one --list-remote test/th*
$ hgedenapi book --list-remote test/one --list-remote test/th*
test/one 26805aba1e600a82e93661149f2313866a221a7b
test/three 051cf22dff5ca70a5ba3d06d1f9dd08407dfd1a6
match with SQL wildcards doesn't match arbitrary things (should match nothing)
$ hgmn book --list-remote t__t/*
$ hgedenapi book --list-remote t__t/*
match with SQL wildcards does match things with those characters
$ hgmn book --list-remote special/__test*
$ hgedenapi book --list-remote special/__test*
special/__test__ 112478962961147124edd43549aedd1a335e44bf

View File

@ -46,7 +46,7 @@ _definitelyhash = re.compile(r"^[a-f0-9]{40}$").search
configtable = {}
configitem = registrar.configitem(configtable)
# Use the http Edenapi protocol to fetch bookmarks
configitem("infinitepush", "httpbookmarks", default=False)
configitem("infinitepush", "httpbookmarks", default=True)
def extsetup(ui):

View File

@ -434,7 +434,7 @@ coreconfigitem("pull", "automigrate", default=True)
# Practically, 100k commit data takes about 200MB memroy (or 400MB if
# duplicated in Python / Rust).
coreconfigitem("pull", "buffer-commit-count", default=(util.istest() and 5 or 100000))
coreconfigitem("pull", "httpbookmarks", default=False)
coreconfigitem("pull", "httpbookmarks", default=True)
coreconfigitem("pull", "httphashprefix", default=False)
coreconfigitem("pull", "httpcommitgraph", default=False)
coreconfigitem("pull", "httpmutation", default=True)

View File

@ -100,7 +100,6 @@ Pull:
$ hg pull -B master
pulling from test:e1
DEBUG eagerepo::api: bookmarks master
DEBUG edenscm::mercurial::eagerpeer: listkeyspatterns(bookmarks, ['master']) = sortdict([('master', '23d30dc6b70380b2d939023947578ae0e0198999')])
DEBUG eagerepo::api: bookmarks master
DEBUG edenscm::mercurial::eagerpeer: listkeyspatterns(bookmarks, ['master']) = sortdict([('master', '23d30dc6b70380b2d939023947578ae0e0198999')])
DEBUG eagerepo::api: bookmarks master
@ -112,7 +111,6 @@ Pull:
$ hg pull -r $B
pulling from test:e1
DEBUG eagerepo::api: bookmarks master
DEBUG edenscm::mercurial::eagerpeer: listkeyspatterns(bookmarks, ['master']) = sortdict([('master', '23d30dc6b70380b2d939023947578ae0e0198999')])
DEBUG eagerepo::api: commit_known 99dac869f01e09fe3d501fa645ea524af80d498f
TRACE edenscm::mercurial::eagerpeer: known 99dac869f01e09fe3d501fa645ea524af80d498f: True
DEBUG eagerepo::api: bookmarks master
@ -160,7 +158,6 @@ Clone (using edenapi clonedata, bypassing peer interface):
tip commit: 23d30dc6b70380b2d939023947578ae0e0198999
fetching selected remote bookmarks
DEBUG eagerepo::api: bookmarks master
DEBUG edenscm::mercurial::eagerpeer: listkeyspatterns(bookmarks, ['master']) = sortdict([('master', '23d30dc6b70380b2d939023947578ae0e0198999')])
Clone:
@ -172,7 +169,6 @@ Clone:
tip commit: 23d30dc6b70380b2d939023947578ae0e0198999
fetching selected remote bookmarks
DEBUG eagerepo::api: bookmarks master
DEBUG edenscm::mercurial::eagerpeer: listkeyspatterns(bookmarks, ['master']) = sortdict([('master', '23d30dc6b70380b2d939023947578ae0e0198999')])
$ cd cloned

View File

@ -3,8 +3,6 @@
$ configure modern
$ setconfig paths.default=test:e1 ui.traceback=1
$ setconfig infinitepush.httpbookmarks=1
$ setconfig pull.httpbookmarks=1
$ setconfig pull.httphashprefix=1
$ setconfig pull.httpcommitgraph=1
$ setconfig exchange.httpcommitlookup=1