facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2025-01-08 06:37:26 +03:00
Code Issues Projects Releases Wiki Activity

stop honoring the older fb303 shutdown() call

Browse Source 
Summary:
Don't honor the older (and deprecated) fb303 shutdown() call.  The
`initiateShutdown()` call should always be used instead now, which includes a
bit more diagnostic information that we log to describe why the shutdown was
requested.

Reviewed By: wez, strager

Differential Revision: D15572123

fbshipit-source-id: 413be611313c9ae490673a2b34742e512cf8e5ea
This commit is contained in:
Adam Simpkins 2019-06-05 11:47:01 -07:00 committed by Facebook Github Bot
parent 3528f40c14
commit 51c8da5469
2 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eden/fs/service/EdenServiceHandler.cpp
View File

@ -1318,11 +1318,6 @@ Future<Unit> EdenServiceHandler::future_invalidateKernelInodeCache(
#endif // !_WIN32
}
void EdenServiceHandler::shutdown() {
auto helper = INSTRUMENT_THRIFT_CALL(INFO);
server_->stop();
}
void EdenServiceHandler::enableTracing() {
XLOG(INFO) << "Enabling tracing";
eden::enableTracing();

11
eden/fs/service/EdenServiceHandler.h
View File

@ -189,16 +189,7 @@ class EdenServiceHandler : virtual public StreamingEdenServiceSvIf,
int64_t unblockFault(std::unique_ptr<UnblockFaultArg> info) override;
/**
* When this Thrift handler is notified to shutdown, it notifies the
* EdenServer to shut down, as well. We prefer that external
* clients use initiateShutdown() instead so that we can log some
* context.
*/
void shutdown() override;
/**
* A thrift client has requested that we shutdown and provided
* the reason why.
* A thrift client has requested that we shutdown.
*/
void initiateShutdown(std::unique_ptr<std::string> reason) override;