From 52a9bdd6a5598a582ab9ac678d5af68cce348211 Mon Sep 17 00:00:00 2001 From: Liubov Dmitrieva Date: Mon, 13 Aug 2018 11:58:26 -0700 Subject: [PATCH] eliminate excessive thousands of lines logging Summary: all that places logged all list of HgNodeHash Reviewed By: StanislavGlebik Differential Revision: D9242904 fbshipit-source-id: 42a98b04986f2ed432a8956828356bd5b9bcaa88 --- bundle2-resolver/src/resolver.rs | 4 +--- hgproto/src/commands.rs | 1 - repo_client/src/client/mod.rs | 4 +--- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/bundle2-resolver/src/resolver.rs b/bundle2-resolver/src/resolver.rs index 365cde85f4..484c9e6d8b 100644 --- a/bundle2-resolver/src/resolver.rs +++ b/bundle2-resolver/src/resolver.rs @@ -47,11 +47,9 @@ pub fn resolve( repo: Arc, logger: Logger, scuba_logger: ScubaSampleBuilder, - heads: Vec, + _heads: Vec, bundle2: BoxStream, ) -> BoxFuture { - info!(logger, "unbundle heads {:?}", heads); - let resolver = Bundle2Resolver::new(repo, logger, scuba_logger); let bundle2 = resolver.resolve_start_and_replycaps(bundle2); diff --git a/hgproto/src/commands.rs b/hgproto/src/commands.rs index 5475dcbae6..71cacba92a 100644 --- a/hgproto/src/commands.rs +++ b/hgproto/src/commands.rs @@ -61,7 +61,6 @@ impl HgCommandHandler { where S: Stream + Send + 'static, { - debug!(self.logger, "Got request: {:?}", req); let hgcmds = &self.commands; match req { diff --git a/repo_client/src/client/mod.rs b/repo_client/src/client/mod.rs index 23a06ee36c..f4509c179a 100644 --- a/repo_client/src/client/mod.rs +++ b/repo_client/src/client/mod.rs @@ -281,7 +281,7 @@ impl RepoClient { } fn gettreepack_untimed(&self, params: GettreepackArgs) -> BoxStream { - info!(self.logger, "gettreepack {:?}", params); + debug!(self.logger, "gettreepack"); if !params.directories.is_empty() { // This param is not used by core hg, don't worry about implementing it now @@ -438,7 +438,6 @@ impl HgCommands for RepoClient { fn heads(&self) -> HgCommandRes> { // Get a stream of heads and collect them into a HashSet // TODO: directly return stream of heads - let logger = self.logger.clone(); let mut scuba_logger = self.scuba_logger(ops::HEADS, None); self.repo @@ -447,7 +446,6 @@ impl HgCommands for RepoClient { .collect() .map(|v| v.into_iter().collect()) .from_err() - .inspect(move |resp| debug!(logger, "heads response: {:?}", resp)) .traced(&self.trace, ops::HEADS, trace_args!()) .timed(move |stats, _| { scuba_logger