facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 06:47:41 +03:00
Code Issues Projects Releases Wiki Activity

prevent enabled command fallback to Python when it's run without --help

Browse Source 
Summary:
I'm introducing a new Rust-only command implementation, and I never
want it to fall back to Python help, even if it's run without a
required option. Therefore, handle
DisplayHelpOnMissingArgumentOrSubcommand as well as DisplayHelp.

Reviewed By: fanzeyi

Differential Revision: D44560239

fbshipit-source-id: 43c418da3c980a34a11277c82bf350822b0bc71b
This commit is contained in:
Chad Austin 2023-03-31 11:08:05 -07:00 committed by Facebook GitHub Bot
parent c682ccc661
commit 56c1538580
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
eden/fs/cli_rs/edenfsctl/src/main.rs
View File

@ -183,7 +183,8 @@ fn wrapper_main() -> Result<i32> {
// UnknownArgument (whether or not --help was requested) and we
// should fall back to Python.
Err(e) => {
if e.kind() == clap::ErrorKind::DisplayHelp
if (e.kind() == clap::ErrorKind::DisplayHelp
|| e.kind() == clap::ErrorKind::DisplayHelpOnMissingArgumentOrSubcommand)
&& should_use_rust_help(std::env::args(), &None).unwrap_or(false)
{
e.exit()