facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2025-01-08 14:46:47 +03:00
Code Issues Projects Releases Wiki Activity

fix a file descriptor leak in the temporary file code

Browse Source 
Summary:
The new temporary file code added in D20885160 was missing a call to close the
underlying file in the `__exit__()` function.

Reviewed By: xavierd

Differential Revision: D21271901

fbshipit-source-id: 653258d471421edd08b473654ae3d0503f3c6829
This commit is contained in:
Adam Simpkins 2020-04-28 12:09:40 -07:00 committed by Facebook GitHub Bot
parent 4eeab3b81b
commit 606e928233
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
eden/test_support/temporary_directory.py
View File

@ -192,7 +192,7 @@ class TemporaryFileBase(Generic[IOType]):
exc_value: Optional[BaseException], exc_value: Optional[BaseException],
tb: Optional[types.TracebackType], tb: Optional[types.TracebackType],
) -> None: ) -> None:
pass self.file.close()
class TemporaryTextFile(TemporaryFileBase[TextIO]): class TemporaryTextFile(TemporaryFileBase[TextIO]):