facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 15:27:13 +03:00
Code Issues Projects Releases Wiki Activity

revlog: avoid an expensive string copy

Browse Source 
This showed up in a statprof profile of "hg svn rebuildmeta", which
is read-intensive on the changelog.  This two-line patch improved
the performance of that command by 10%.
This commit is contained in:
Bryan O'Sullivan 2012-04-12 20:26:33 -07:00
parent 2bbef572af
commit 62554752c6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mercurial/revlog.py
View File

@ -818,7 +818,7 @@ class revlog(object):
df.close()
self._addchunk(offset, d)
if readahead > length:
return d[:length]
return util.buffer(d, 0, length)
return d
def _getchunk(self, offset, length):
@ -831,7 +831,7 @@ class revlog(object):
if cachestart >= 0 and cacheend <= l:
if cachestart == 0 and cacheend == l:
return d # avoid a copy
return d[cachestart:cacheend]
return util.buffer(d, cachestart, cacheend - cachestart)
return self._loadchunk(offset, length)
@ -864,7 +864,7 @@ class revlog(object):
def revdiff(self, rev1, rev2):
"""return or calculate a delta between two revisions"""
if rev1 != nullrev and self.deltaparent(rev2) == rev1:
return self._chunk(rev2)
return str(self._chunk(rev2))
return mdiff.textdiff(self.revision(self.node(rev1)),
self.revision(self.node(rev2)))
@ -921,7 +921,7 @@ class revlog(object):
self._chunkraw(base, rev)
if text is None:
text = self._chunkbase(base)
text = str(self._chunkbase(base))
bins = [self._chunk(r) for r in chain]
text = mdiff.patches(text, bins)