facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-07-07 07:26:34 +03:00
Code Issues Projects Releases Wiki Activity

clippy: prevent holding a span guard over an .await

Browse Source 
Summary:
X-link: https://github.com/facebookresearch/Private-ID/pull/119

We should probably lint against using an `.enter()` guard over `.await` points for the reasons outlined in https://docs.rs/tracing/latest/tracing/struct.Span.html#in-asynchronous-code.

Reviewed By: zertosh

Differential Revision: D50528695

fbshipit-source-id: 82fcc97a83b5d820c8673e6f56794dc47fd4d77f
This commit is contained in:
David Barsky 2023-11-16 07:31:54 -08:00 committed by Facebook GitHub Bot
parent 312a43d6d2
commit 6fb1b68950
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clippy.toml
View File

@ -1 +1,5 @@
too-many-lines-threshold = 200
await-holding-invalid-types = [
{ path = "tracing::span::Entered", reason = "`Entered` is not aware when a function is suspended: https://docs.rs/tracing/latest/tracing/struct.Span.html#in-asynchronous-code" },
{ path = "tracing::span::EnteredSpan", reason = "`EnteredSpan` is not aware when a function is suspended: https://docs.rs/tracing/latest/tracing/struct.Span.html#in-asynchronous-code" },
]