facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 00:14:35 +03:00
Code Issues Projects Releases Wiki Activity

http2: track available data as it changes instead of recomputing it

Browse Source 
With a large amount of available data, this computation can become
costly.
This commit is contained in:
Brendan Cully 2013-02-01 14:41:33 -08:00
parent cc84391aeb
commit 720c8502c6
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
mercurial/httpclient/_readers.py
View File

@ -57,10 +57,21 @@ class AbstractReader(object):
def __init__(self):
self._finished = False
self._done_chunks = []
self.available_data = 0
@property
def available_data(self):
return sum(map(len, self._done_chunks))
def addchunk(self, data):
self._done_chunks.append(data)
self.available_data += len(data)
def pushchunk(self, data):
self._done_chunks.insert(0, data)
self.available_data += len(data)
def popchunk(self):
b = self._done_chunks.pop(0)
self.available_data -= len(b)
return b
def done(self):
return self._finished
@ -83,6 +94,7 @@ class AbstractReader(object):
self._done_chunks.insert(0, reinsert)
result = ''.join(blocks)
assert len(result) == amt or (self._finished and len(result) < amt)
self.available_data -= amt
return result
def _load(self, data): # pragma: no cover
@ -121,7 +133,7 @@ class AbstractSimpleReader(AbstractReader):
assert not self._finished, (
'tried to add data (%r) to a closed reader!' % data)
logger.debug('%s read an additional %d data', self.name, len(data))
self._done_chunks.append(data)
self.addchunk(data)
class CloseIsEndReader(AbstractSimpleReader):
@ -190,6 +202,6 @@ class ChunkedReader(AbstractReader):
self._finished = True
logger.debug('closing chunked reader due to chunk of length 0')
return
self._done_chunks.append(data[block_start:block_start + amt])
self.addchunk(data[block_start:block_start + amt])
position = block_start + amt + len(self._eol)
# no-check-code