facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-12 09:48:05 +03:00
Code Issues Projects Releases Wiki Activity

edenapi: move active transfer check into loop body

Browse Source 
Summary: Due to the structure of this loop, we were unnecessarily blocking and polling when all curl transfers were already complete. To fix this, move the loop condition check to the middle of the loop.

Reviewed By: quark-zju

Differential Revision: D15124823

fbshipit-source-id: 92b7eee83cbfd62d590c21893f3235e1ca04fcec
This commit is contained in:
Arun Kulshreshtha 2019-04-29 13:14:47 -07:00 committed by Facebook Github Bot
parent 7abc07832c
commit 77ac4bc5c2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/edenapi/src/curl/driver.rs
View File

@ -90,7 +90,7 @@ impl<H: Handler> MultiDriver<H> {
let mut failed = Vec::new();
let mut i = 0;
while in_progress > 0 {
loop {
log::trace!(
"Iteration {}: {}/{} transfers complete",
i,
@ -126,6 +126,11 @@ impl<H: Handler> MultiDriver<H> {
break;
}
if in_progress == 0 {
log::debug!("All transfers finished successfully.");
break;
}
let timeout = self.multi.get_timeout()?.unwrap_or(DEFAULT_TIMEOUT);
log::trace!("Waiting for I/O with timeout: {:?}", &timeout);