convert: make commit constructor clearer and less magical

hgext/convert/__init__.py

@@ -193,7 +193,7 @@ class convert(object):
         c = self.commitcache[rev]
         files = self.source.getchanges(rev)
 
-        do_copies = (hasattr(c, 'copies') and hasattr(self.dest, 'copyfile'))
+        do_copies = hasattr(self.dest, 'copyfile')
 
         for f, v in files:
             try:

hgext/convert/common.py

@@ -3,16 +3,20 @@
 class NoRepo(Exception): pass
 
 class commit(object):
-    def __init__(self, **parts):
+    def __init__(self, author, date, desc, parents, branch=None, rev=None,
+                 copies={}):
         self.rev = None
         self.branch = None
-
-        for x in "author date desc parents".split():
-            if not x in parts:
-                raise util.Abort("commit missing field %s" % x)
-        self.__dict__.update(parts)
-        if not self.desc or self.desc.isspace():
+        self.author = author
+        self.date = date
+        if desc and not desc.isspace():
+            self.desc = desc
+        else:
             self.desc = '*** empty log message ***'
+        self.parents = parents
+        self.branch = branch
+        self.rev = rev
+        self.copies = copies
 
 class converter_source(object):
     """Conversion source interface"""