facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 22:37:37 +03:00
Code Issues Projects Releases Wiki Activity

rename LogEvent fields so names in code match names in the log

Browse Source 
Summary:
Multiple times I've gotten mixed up by the different casing of the
LogEvent fields versus the names in the structured log. Change the
field names to match the log names.

Reviewed By: genevievehelsel

Differential Revision: D19585307

fbshipit-source-id: 3ccbb9ec5e18155367bc85e9db00bc8d556812c4
This commit is contained in:
Chad Austin 2020-01-31 10:40:37 -08:00 committed by Facebook Github Bot
parent e033f203f7
commit 7c6efd32e7
2 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
eden/fs/service/EdenServer.cpp
View File

@ -1045,10 +1045,10 @@ folly::Future<std::shared_ptr<EdenMount>> EdenServer::mount(
})
.thenTry([this, mountStopWatch, doTakeover, edenMount](auto&& t) {
FinishedMount event;
event.repoType = edenMount->getConfig()->getRepoType();
event.repoSource =
event.repo_type = edenMount->getConfig()->getRepoType();
event.repo_source =
basename(edenMount->getConfig()->getRepoSource()).str();
event.isTakeover = doTakeover;
event.is_takeover = doTakeover;
event.duration =
std::chrono::duration<double>{mountStopWatch.elapsed()}
.count();

36
eden/fs/telemetry/LogEvent.h
View File

@ -92,17 +92,17 @@ struct FinishedCheckout {
struct FinishedMount {
static constexpr const char* type = "mount";
std::string repoType;
std::string repoSource;
bool isTakeover = false;
std::string repo_type;
std::string repo_source;
bool is_takeover = false;
double duration = 0.0;
bool success = false;
bool clean = false;
void populate(DynamicEvent& event) const {
event.addString("repo_type", repoType);
event.addString("repo_source", repoSource);
event.addBool("is_takeover", isTakeover);
event.addString("repo_type", repo_type);
event.addString("repo_source", repo_source);
event.addBool("is_takeover", is_takeover);
event.addDouble("duration", duration);
event.addBool("success", success);
event.addBool("clean", clean);
@ -112,12 +112,12 @@ struct FinishedMount {
struct FuseError {
static constexpr const char* type = "fuse_error";
int64_t fuseOp = 0;
int64_t errorCode = 0;
int64_t fuse_op = 0;
int64_t error_code = 0;
void populate(DynamicEvent& event) const {
event.addInt("fuse_op", fuseOp);
event.addInt("error_code", errorCode);
event.addInt("fuse_op", fuse_op);
event.addInt("error_code", error_code);
}
};
@ -126,35 +126,35 @@ struct RocksDbAutomaticGc {
double duration = 0.0;
bool success = false;
int64_t sizeBefore = 0;
int64_t sizeAfter = 0;
int64_t size_before = 0;
int64_t size_after = 0;
void populate(DynamicEvent& event) const {
event.addDouble("duration", duration);
event.addBool("success", success);
event.addInt("size_before", sizeBefore);
event.addInt("size_after", sizeAfter);
event.addInt("size_before", size_before);
event.addInt("size_after", size_after);
}
};
struct ThriftError {
static constexpr const char* type = "thrift_error";
std::string thriftMethod;
std::string thrift_method;
void populate(DynamicEvent& event) const {
event.addString("method", thriftMethod);
event.addString("thrift_method", thrift_method);
}
};
struct ThriftAuthFailure {
static constexpr const char* type = "thrift_auth_failure";
std::string thriftMethod;
std::string thrift_method;
std::string reason;
void populate(DynamicEvent& event) const {
event.addString("method", thriftMethod);
event.addString("thrift_method", thrift_method);
event.addString("reason", reason);
}
};