facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 06:18:07 +03:00
Code Issues Projects Releases Wiki Activity

Remove language setting

Browse Source 
Summary:
We only support `en` at the moment, so let's remove the "Language" setting from the dropdown. It's taking up room which distracts from settings which actually do something.

Eventually I'd love if we supported more languages. All the infra is in place, we'd just need people to translate stuff for us. This matters more for OSS usage than internal usage.

Reviewed By: sggutier

Differential Revision: D50100534

fbshipit-source-id: f2bd8888d531d570263e084fec1e58f52c2defa2
This commit is contained in:
Evan Krause 2023-10-09 16:12:32 -07:00 committed by Facebook GitHub Bot
parent b1c5e71c04
commit 7def22784e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
addons/isl/src/SettingsTooltip.tsx
View File

@ -73,13 +73,14 @@ function SettingsDropdown() {
<Setting title={<T>Commits</T>}>
<RenderCompactSetting />
</Setting>
<Setting
{/* TODO: enable this setting when there is actually a chocie to be made here. */}
{/* <Setting
title={<T>Language</T>}
description={<T>Locale for translations used in the UI. Currently only en supported.</T>}>
<VSCodeDropdown value="en" disabled>
<VSCodeOption value="en">en</VSCodeOption>
</VSCodeDropdown>
</Setting>
</Setting> */}
{repoInfo?.type !== 'success' ? (
<Icon icon="loading" />
) : repoInfo?.codeReviewSystem.type === 'github' ? (