facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-12-26 06:21:48 +03:00
Code Issues Projects Releases Wiki Activity

fix eden redirect fixup properly now

Browse Source 
Summary:
ghostbooleans

Apparently I didn't test for the positive case in my previous diff that introduces this check :(

Reviewed By: xavierd

Differential Revision: D23698179

fbshipit-source-id: 95a28cc13bff5e325214b6a398e19c821b5ae17f
This commit is contained in:
Zeyi (Rice) Fan 2020-09-15 09:34:46 -07:00 committed by Facebook GitHub Bot
parent d1601bdd86
commit 7f6479f790
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eden/fs/cli/redirect.py
View File

@ -407,9 +407,8 @@ class Redirection:
def apply(self, checkout: EdenCheckout):
disposition = self.remove_existing(checkout)
if (
disposition == RepoPathDisposition.IS_NON_EMPTY_DIR
and self.type == RedirectionType.SYMLINK
if disposition == RepoPathDisposition.IS_NON_EMPTY_DIR and (
self.type == RedirectionType.SYMLINK
or (self.type == RedirectionType.BIND and sys.platform == "win32")
):
# Part of me would like to show this error even if we're going