facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-07-14 22:00:35 +03:00
Code Issues Projects Releases Wiki Activity

config: prevent requires from the backing repo to affect symlinks and FilteredFS

Browse Source 
Summary:
If a new repo was to be cloned with symlinks disabled on Windows, this would make the repo have a wrong config for symlinks.
In order for symlinks to be enabled for a working copy, they have to be enabled both in the EdenFS config for that checkout as well as having them inabled in hg by having `windowssymlinks` in `.hg/requires`.
Having symlinks enabled **in only one of the two** can cause really wonky behavior.

Some users were reporting having issues with symlinks being partially enabled on their working copies. This was caused by the backing repo having `windowssymlinks` enabled on the backing repo, since the requires is copied from there into the newly cloned repo.

This diff makes changes to that, preventing copying the requires file into a new one for both symlinks and FilteredFS, since both can be affected by this kind of behavior.

Reviewed By: MichaelCuevas

Differential Revision: D52311410

fbshipit-source-id: bca76757f1b9b6f2cafd4e024b8eafc0735e7e89
This commit is contained in:
Saul Gutierrez 2023-12-19 18:09:50 -08:00 committed by Facebook GitHub Bot
parent e3b941c99e
commit 81e5df1336
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
eden/fs/cli/hg_util.py
View File

@ -120,6 +120,8 @@ def get_requires_data(checkout: EdenCheckout) -> str:
# the backing repository's dirstate.
requires.discard("sqldirstate")
requires.discard("treedirstate")
requires.discard("windowssymlinks")
requires.discard("edensparse")
if checkout.get_config().enable_windows_symlinks:
requires.add("windowssymlinks")