facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 22:37:37 +03:00
Code Issues Projects Releases Wiki Activity

make Thrift Tracebus size configurable with EdenConfig

Browse Source 
Summary: make Thrift Tracebus size configurable with EdenConfig

Reviewed By: kmancini

Differential Revision: D45362951

fbshipit-source-id: 9590b94a95fbd389889d91cf5ed2cf4570684001
This commit is contained in:
Revathy Kasipandian 2023-04-28 08:40:40 -07:00 committed by Facebook GitHub Bot
parent df251e1802
commit 8860d083e7
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eden/fs/config/EdenConfig.h
View File

@ -840,6 +840,11 @@ class EdenConfig : private ConfigSettingManager {
25000,
this};
ConfigSetting<size_t> ThriftTraceBusCapacity{
"telemetry:thrift-tracebus-capacity",
25000,
this};
/**
* Controls whether EdenFS logs inode state changes to Tracebus or not.
*/

6
eden/fs/service/EdenServiceHandler.cpp
View File

@ -208,8 +208,6 @@ class PrefetchFetchContext : public ObjectFetchContext {
std::string_view endpoint_;
};
constexpr size_t kTraceBusCapacity = 25000;
/**
* Lives as long as a Thrift request and primarily exists to record logging and
* telemetry.
@ -443,7 +441,9 @@ EdenServiceHandler::EdenServiceHandler(
thriftRequestActivityBuffer_(initThriftRequestActivityBuffer()),
thriftRequestTraceBus_(TraceBus<ThriftRequestTraceEvent>::create(
"ThriftRequestTrace",
kTraceBusCapacity)) {
server_->getServerState()
->getEdenConfig()
->ThriftTraceBusCapacity.getValue())) {
struct HistConfig {
int64_t bucketSize{250};
int64_t min{0};