mirror of
https://github.com/facebook/sapling.git
synced 2024-10-08 15:57:43 +03:00
posixfile_nt: set closed early
Exceptions in __init__ may leave us with close undefined in __del__
This commit is contained in:
parent
213ea70ab4
commit
88e99c1e5f
@ -227,6 +227,9 @@ class posixfile_nt(object):
|
||||
# but does not work at all. wrap win32 file api instead.
|
||||
|
||||
def __init__(self, name, mode='rb'):
|
||||
self.closed = False
|
||||
self.name = name
|
||||
self.mode = mode
|
||||
access = 0
|
||||
if 'r' in mode or '+' in mode:
|
||||
access |= win32file.GENERIC_READ
|
||||
@ -250,9 +253,6 @@ class posixfile_nt(object):
|
||||
0)
|
||||
except pywintypes.error, err:
|
||||
raise WinIOError(err, name)
|
||||
self.closed = False
|
||||
self.name = name
|
||||
self.mode = mode
|
||||
|
||||
def __iter__(self):
|
||||
for line in self.read().splitlines(True):
|
||||
|
Loading…
Reference in New Issue
Block a user