facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-08 07:49:11 +03:00
Code Issues Projects Releases Wiki Activity

check-code: improve test-check-code error diffs

Browse Source 
Whenever check-code finds something wrong, the diffs it
generated were fairly hard to read.

The problem is that check-code before this change
would list files that were white listed using
no- check- code but without a glob marker.

Whereas, the test-check-code.t expected output has
no-che?k-code (glob) in order to avoid having itself
flagged as a file to skip.

Thus, in addition to any lines relating to things you
did wrong, all of the white-listed files are listed as
changed.

There is no reason for things to be this painful.

This change makes the output from check-code.py match
the expected output in test-check-code.t
This commit is contained in:
timeless 2015-12-24 19:32:14 +00:00
parent 07328dec9f
commit 8dd6ee4d9a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/check-code.py
View File

@ -478,7 +478,13 @@ def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,
name, match, f)
continue
if "no-" "check-code" in pre:
print "Skipping %s it has no-" "check-code" % f
# If you're looking at this line, it's because a file has:
# no- check- code
# but the reason to output skipping is to make life for
# tests easier. So, instead of writing it with a normal
# spelling, we write it with the expected spelling from
# tests/test-check-code.t
print "Skipping %s it has no-che?k-code (glob)" % f
return "Skip" # skip checking this file
for p, r in filters:
post = re.sub(p, r, post)