facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 16:31:02 +03:00
Code Issues Projects Releases Wiki Activity

hint: write to stdout in streampager

Browse Source 
Summary:
Users get used to hints at the end of the output, not in a separate panel in
streampager. Make it so.

Reviewed By: andll

Differential Revision: D29400532

fbshipit-source-id: 41dc5d20f44a315bc0235ca3cb7857ae8955d3ad
This commit is contained in:
Jun Wu 2021-06-25 15:17:57 -07:00 committed by Facebook GitHub Bot
parent 0183787d11
commit 909411bb1c
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
eden/scm/edenscm/mercurial/hintutil.py
View File

@ -82,13 +82,21 @@ def show(ui):
return name in acked or ui.configbool("hint", "ack-%s" % name)
names = []
if util.mainio.is_pager_active():
# For stream pager, people expect hints to be at the end, not in a
# separate panel. Make it so. When the pager is active, we know that the
# stdout is not being redirected to a file or pipe, so this won't affect
# automation reading stdout.
write = ui.write
else:
write = ui.write_err
for name, msg in messages:
if not isacked(name):
ui.write_err("%s\n" % msg.rstrip(), notice=_("hint[%s]") % name)
write("%s\n" % msg.rstrip(), notice=_("hint[%s]") % name)
names.append(name)
if names and not isacked("hint-ack"):
msg = _("use 'hg hint --ack %s' to silence these hints\n") % " ".join(names)
ui.write_err(msg, notice=_("hint[%s]") % "hint-ack")
write(msg, notice=_("hint[%s]") % "hint-ack")
messages[:] = []
triggered.clear()