facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2025-01-02 18:11:56 +03:00
Code Issues Projects Releases Wiki Activity

Remove defaulted move constructors/assignment operators that are implicitly deleted

Browse Source 
Summary:
Some newer versions of `clang` (such as Apple's version 11) will warn/error out if a constructor or assignment operator
marked `default` is implicitly deleted (e.g., if the object contains a non-moveable/non-copyable member). This diff
removes all such defaulted constructors/assignment operators, which I ran into while building `edenfs` on my Macbook Pro.

Reviewed By: chadaustin, strager

Differential Revision: D15901794

fbshipit-source-id: 794ed8377693a6735bb567635dc919bc678751a4
This commit is contained in:
Jon Maltiel Swenson 2019-06-19 14:23:07 -07:00 committed by Facebook Github Bot
parent 678000ac92
commit 938eb990a6
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
eden/fs/fuse/RequestData.h
View File

@ -36,8 +36,8 @@ class RequestData : public folly::RequestData {
static const std::string kKey; static const std::string kKey;
RequestData(const RequestData&) = delete; RequestData(const RequestData&) = delete;
RequestData& operator=(const RequestData&) = delete; RequestData& operator=(const RequestData&) = delete;
RequestData(RequestData&&) = default; RequestData(RequestData&&) = delete;
RequestData& operator=(RequestData&&) = default; RequestData& operator=(RequestData&&) = delete;
explicit RequestData( explicit RequestData(
FuseChannel* channel, FuseChannel* channel,
const fuse_in_header& fuseHeader, const fuse_in_header& fuseHeader,

4
eden/fs/inodes/InodeMap.h
View File

@ -106,8 +106,8 @@ class InodeMap {
explicit InodeMap(EdenMount* mount); explicit InodeMap(EdenMount* mount);
virtual ~InodeMap(); virtual ~InodeMap();
InodeMap(InodeMap&&) = default; InodeMap(InodeMap&&) = delete;
InodeMap& operator=(InodeMap&&) = default; InodeMap& operator=(InodeMap&&) = delete;
/** /**
* Initialize the InodeMap * Initialize the InodeMap

4
eden/fs/journal/JournalDelta.h
View File

@ -53,8 +53,8 @@ class JournalDelta {
enum Renamed { RENAME }; enum Renamed { RENAME };
enum Replaced { REPLACE }; enum Replaced { REPLACE };
JournalDelta() = default; JournalDelta() = default;
JournalDelta(JournalDelta&&) = default; JournalDelta(JournalDelta&&) = delete;
JournalDelta& operator=(JournalDelta&&) = default; JournalDelta& operator=(JournalDelta&&) = delete;
JournalDelta(const JournalDelta&) = delete; JournalDelta(const JournalDelta&) = delete;
JournalDelta& operator=(const JournalDelta&) = delete; JournalDelta& operator=(const JournalDelta&) = delete;
JournalDelta(RelativePathPiece fileName, Created); JournalDelta(RelativePathPiece fileName, Created);

4
eden/fs/service/EdenServiceHandler.cpp
View File

@ -117,8 +117,8 @@ namespace /* anonymous namespace for helper functions */ {
// Helper class to log where the request completes in Future // Helper class to log where the request completes in Future
class ThriftLogHelper { class ThriftLogHelper {
public: public:
ThriftLogHelper(ThriftLogHelper&&) = default; ThriftLogHelper(ThriftLogHelper&&) = delete;
ThriftLogHelper& operator=(ThriftLogHelper&&) = default; ThriftLogHelper& operator=(ThriftLogHelper&&) = delete;
template <typename... Args> template <typename... Args>
ThriftLogHelper( ThriftLogHelper(