facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-12-29 08:02:24 +03:00
Code Issues Projects Releases Wiki Activity

remotefilelog: do not assume range(len(cl)) are valid revs in _linkrev

Browse Source 
Summary: `range(len(cl))` contains invalid revs with segments backend.

Reviewed By: DurhamG

Differential Revision: D23411209

fbshipit-source-id: 2f83a5402bb46824cf38871926c1954507b64b56
This commit is contained in:
Jun Wu 2020-08-31 11:55:57 -07:00 committed by Facebook GitHub Bot
parent ff2d572717
commit 96548cade8
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
eden/scm/edenscm/hgext/remotefilelog/remotefilectx.py
View File

@ -138,7 +138,9 @@ class remotefilectx(context.filectx):
repo.ui, _("scanning for linkrev of %s") % path
) as prog:
perftrace.tracevalue("Path", path)
for i, rev in enumerate(range(len(cl) - 1, 0, -1)):
allrevs = repo.revs("_all()")
allrevs.sort(reverse=True)
for i, rev in enumerate(allrevs):
prog.value = i
node = cl.node(rev)
data = cl.read(node) # get changeset data (we avoid object creation)
@ -146,7 +148,7 @@ class remotefilectx(context.filectx):
# The file has been touched, check if the hash is what we're
# looking for.
if fileid == mfl[data[0]].read().get(path):
perftrace.tracevalue("Distance", len(cl) - rev)
perftrace.tracevalue("Distance", i)
return rev
# Couldn't find the linkrev. This should generally not happen, and will