tags: do not fail if tags.cache is corrupted (issue2444)

This file is not critical for hg, so we can safely
swallow the ValueError

mercurial/tags.py

@@ -176,16 +176,23 @@ def _readtagcache(ui, repo):
     cacheheads = []                     # list of headnode
     cachefnode = {}                     # map headnode to filenode
     if cachefile:
-        for line in cachelines:
-            if line == "\n":
-                break
-            line = line.rstrip().split()
-            cacherevs.append(int(line[0]))
-            headnode = bin(line[1])
-            cacheheads.append(headnode)
-            if len(line) == 3:
-                fnode = bin(line[2])
-                cachefnode[headnode] = fnode
+        try:
+            for line in cachelines:
+                if line == "\n":
+                    break
+                line = line.rstrip().split()
+                cacherevs.append(int(line[0]))
+                headnode = bin(line[1])
+                cacheheads.append(headnode)
+                if len(line) == 3:
+                    fnode = bin(line[2])
+                    cachefnode[headnode] = fnode
+        except (ValueError, TypeError):
+            # corruption of tags.cache, just recompute it
+            ui.warn(_('.hg/tags.cache is corrupt, rebuilding it\n'))
+            cacheheads = []
+            cacherevs = []
+            cachefnode = {}
 
     tipnode = repo.changelog.tip()
     tiprev = len(repo.changelog) - 1

tests/test-tags.t

@@ -34,6 +34,17 @@ Setup:
   $ cacheexists
   tag cache exists
 
+Try corrupting the cache
+
+  $ echo 'a b\n' > .hg/tags.cache
+  $ hg identify
+  .hg/tags.cache is corrupt, rebuilding it
+  acb14030fe0a tip
+  $ cacheexists
+  tag cache exists
+  $ hg identify
+  acb14030fe0a tip
+
 Create local tag with long name:
 
   $ T=`hg identify --debug --id`