facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 14:28:17 +03:00
Code Issues Projects Releases Wiki Activity

eden: enable capturing process names on macos

Browse Source 
Summary: This turned out to be a lot simpler than I thought it would!

Reviewed By: chadaustin

Differential Revision: D15630515

fbshipit-source-id: 51aeb8b6739cb886c3bca23ab441874ea9ac819c
This commit is contained in:
Wez Furlong 2019-06-04 14:37:25 -07:00 committed by Facebook Github Bot
parent d5a977142b
commit 9ed290a88b
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
eden/fs/utils/ProcessNameCache.cpp
View File

@ -13,6 +13,9 @@
#include <folly/system/ThreadName.h>
#include <optional>
#include "eden/fs/utils/Synchronized.h"
#ifdef __APPLE__
#include <libproc.h> // @manual
#endif
using namespace std::literals;
@ -27,6 +30,19 @@ ProcPidCmdLine getProcPidCmdLine(pid_t pid) {
}
std::string readPidName(pid_t pid) {
#ifdef __APPLE__
char target[PROC_PIDPATHINFO_MAXSIZE];
// libproc is undocumented and unsupported, but the implementation is open
// source:
// https://opensource.apple.com/source/xnu/xnu-2782.40.9/libsyscall/wrappers/libproc/libproc.c
// The return value is 0 on error, otherwise is the length of the buffer.
// It takes care of overflow/truncation.
ssize_t rv = proc_pidpath(pid, target, sizeof(target));
if (rv == 0) {
return folly::to<std::string>("<err:", errno, ">");
}
return std::string{target, target + rv};
#else
char target[256];
const auto fd =
folly::openNoInt(getProcPidCmdLine(pid).data(), O_RDONLY | O_CLOEXEC);
@ -46,6 +62,7 @@ std::string readPidName(pid_t pid) {
// result.
return std::string{target, target + rv};
}
#endif
}
} // namespace facebook::eden::detail