facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-12 01:39:21 +03:00
Code Issues Projects Releases Wiki Activity

remotefilelog: only print debug messages during interactive usage

Browse Source 
Summary: The debug messages from Eden API provide Source Control team members with useful diagnostic information about HTTP data fetching, but they have the potential to be spammy when written to log files. To prevent log spam, let's only print these messages during interactive usage.

Reviewed By: quark-zju

Differential Revision: D16445346

fbshipit-source-id: 001dc75e440eaf797f4f953648453086421f624e
This commit is contained in:
Arun Kulshreshtha 2019-07-23 15:08:40 -07:00 committed by Facebook Github Bot
parent a62bf843cf
commit a491bb06ea
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
edenscm/hgext/remotefilelog/fileserverclient.py
View File

@ -792,7 +792,7 @@ class fileserverclient(object):
% n
)
if edenapi.debug(self.ui):
if self.ui.interactive() and edenapi.debug(self.ui):
self.ui.warn(("%s\n") % msg)
self.ui.metrics.gauge("http_getfiles_revs", n)
@ -809,7 +809,7 @@ class fileserverclient(object):
stats = self.repo.edenapi.get_files(fileids, dpack, progcallback)
if edenapi.debug(self.ui):
if self.ui.interactive() and edenapi.debug(self.ui):
self.ui.warn(_("%s\n") % stats.to_str())
self.ui.metrics.gauge("http_getfiles_time_ms", stats.time_in_millis())
@ -830,7 +830,7 @@ class fileserverclient(object):
% n
)
if edenapi.debug(self.ui):
if self.ui.interactive() and edenapi.debug(self.ui):
self.ui.warn(("%s\n") % msg)
self.ui.metrics.gauge("http_gethistory_revs", n)
@ -847,7 +847,7 @@ class fileserverclient(object):
stats = self.repo.edenapi.get_history(fileids, hpack, depth, progcallback)
if edenapi.debug(self.ui):
if self.ui.interactive() and edenapi.debug(self.ui):
self.ui.warn(_("%s\n") % stats.to_str())
self.ui.metrics.gauge("http_gethistory_time_ms", stats.time_in_millis())

4
edenscm/hgext/treemanifest/__init__.py
View File

@ -546,13 +546,13 @@ def wraprepo(repo):
usehttp = self.ui.configbool("treemanifest", "usehttp")
if edenapi.enabled(self.ui) and usehttp:
try:
if edenapi.debug(self.ui):
if self.ui.interactive() and edenapi.debug(self.ui):
self.ui.warn(_("fetching trees over HTTPS\n"))
dpack, hpack = self.manifestlog.getmutablesharedpacks()
stats = self.edenapi.prefetch_trees(
rootdir, mfnodes, basemfnodes, dpack, depth
)
if edenapi.debug(self.ui):
if self.ui.interactive() and edenapi.debug(self.ui):
self.ui.warn(_("%s\n") % stats.to_str())
return
except Exception as e: