facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 15:27:13 +03:00
Code Issues Projects Releases Wiki Activity

util: move checkosfilename call from path_auditor to opener

Browse Source 
path_auditor is used for checking patterns too, but a pattern is not a valid
filename.

This patch fixes fb1792e89e34, which introduced the bug:

  $ hg log -l3 glob:**.py
  abort: filename contains '*', which is reserved on Windows: mercurial\**.py
This commit is contained in:
Adrian Buehlmann 2011-04-10 19:31:49 +02:00
parent 3828767e58
commit a5b6c426a2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mercurial/util.py
View File

@ -602,9 +602,6 @@ class path_auditor(object):
prefixes.append(prefix)
parts.pop()
r = checkosfilename(path)
if r:
raise Abort("%s: %s" % (r, path))
self.audited.add(path)
# only add prefixes to the cache after checking everything: we don't
# want to add "foo/bar/baz" before checking if there's a "foo/.hg"
@ -916,6 +913,9 @@ class opener(object):
os.chmod(name, self.createmode & 0666)
def __call__(self, path, mode="r", text=False, atomictemp=False):
r = checkosfilename(path)
if r:
raise Abort("%s: %s" % (r, path))
self.auditor(path)
f = os.path.join(self.base, path)