facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 06:18:07 +03:00
Code Issues Projects Releases Wiki Activity

fbcode_builder: fix a minor bug in THRIFT_INCLUDE_DIR argument parsing

Browse Source 
Summary:
Fix a minor bug in the argument parsing for `add_fbthrift_cpp_library()`:
only a single value should be supplied for the `THRIFT_INCLUDE_DIR` argument.
This parameter should not accept a list of arguments.

Reviewed By: strager

Differential Revision: D17125810

fbshipit-source-id: 31f354e4d6299d3626a94f3b4b5ff8c58bb0cf7b
This commit is contained in:
Adam Simpkins 2019-08-29 20:08:15 -07:00 committed by Facebook Github Bot
parent 8e4bb3e91d
commit aa1aefa0f2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
build/fbcode_builder/CMake/FBThriftCppLibrary.cmake
View File

@ -22,8 +22,8 @@ include(FBCMakeParseArgs)
# desired.
function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE)
# Parse the arguments
set(one_value_args INCLUDE_DIR)
set(multi_value_args SERVICES DEPENDS OPTIONS THRIFT_INCLUDE_DIR)
set(one_value_args INCLUDE_DIR THRIFT_INCLUDE_DIR)
set(multi_value_args SERVICES DEPENDS OPTIONS)
fb_cmake_parse_args(
ARG "" "${one_value_args}" "${multi_value_args}" "${ARGN}"
)