facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 07:17:55 +03:00
Code Issues Projects Releases Wiki Activity

tests: remove the testreport= prefix in report.json

Browse Source 
Summary: This prefix makes this file harder because it isn't valid JSON. Per discussion with quark-zju, remove it.

Reviewed By: singhsrb

Differential Revision: D8769139

fbshipit-source-id: f45703c963898202775e90d536dde2894e5029bb
This commit is contained in:
Phil Cohen 2018-07-09 13:27:09 -07:00 committed by Facebook Github Bot
parent f5ed37562e
commit b05631eff7
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/run-tests.py
View File

@ -2661,8 +2661,9 @@ class TextTestRunner(unittest.TextTestRunner):
tres = {"result": res}
outcome[tc.name] = tres
jsonout = json.dumps(outcome, sort_keys=True, indent=4, separators=(",", ": "))
outf.writelines(("testreport =", jsonout))
outf.write(
json.dumps(outcome, sort_keys=True, indent=4, separators=(",", ": "))
)
class TestRunner(object):

12
tests/test-run-tests.t
View File

@ -387,7 +387,7 @@ test --xunit support
test-failure.t
test-success.t
$ cat report.json
testreport ={
{
"test-failure-unicode.t": {
"result": "success"
},
@ -415,7 +415,7 @@ test --xunit support
test-failure-unicode.t
test-failure.t
$ cat output/report.json
testreport ={
{
"test-failure-unicode.t": {
"result": "success"
},
@ -942,7 +942,7 @@ Missing skips or blacklisted skips don't count as executed:
# Ran 0 tests, 2 skipped, 0 failed.
[80]
$ cat report.json
testreport ={
{
"test-bogus.t": {
"result": "skip"
},
@ -1011,7 +1011,7 @@ test for --json
[1]
$ cat report.json
testreport ={
{
"test-failure.t": [\{] (re)
"csys": "\s*[\d\.]{4,5}", ? (re)
"cuser": "\s*[\d\.]{4,5}", ? (re)
@ -1067,7 +1067,7 @@ test for --json
$ f report.json
report.json: file not found
$ cat output/report.json
testreport ={
{
"test-failure.t": [\{] (re)
"csys": "\s*[\d\.]{4,5}", ? (re)
"cuser": "\s*[\d\.]{4,5}", ? (re)
@ -1122,7 +1122,7 @@ Test that failed test accepted through interactive are properly reported:
# Ran 2 tests, 1 skipped, 0 failed.
$ cat report.json
testreport ={
{
"test-failure.t": [\{] (re)
"csys": "\s*[\d\.]{4,5}", ? (re)
"cuser": "\s*[\d\.]{4,5}", ? (re)