facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-12 01:39:21 +03:00
Code Issues Projects Releases Wiki Activity

types: optimize PathComponentBuf::arbitrary

Browse Source 
Summary:
The overhead of generating all the different strings is noticeable when
we start to generate a lot of values.

Reviewed By: quark-zju

Differential Revision: D14877547

fbshipit-source-id: 8a91241ff3e86b6ac9b68197c449ed2be445f941
This commit is contained in:
Stefan Filip 2019-04-14 19:51:35 -07:00 committed by Facebook Github Bot
parent 967cd9c01b
commit b291cdb244
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/types/src/path.rs
View File

@ -490,7 +490,7 @@ impl<'a> Iterator for Components<'a> {
#[cfg(any(test, feature = "for-tests"))]
impl quickcheck::Arbitrary for RepoPathBuf {
fn arbitrary<G: quickcheck::Gen>(g: &mut G) -> Self {
let size = g.gen_range(0, 16);
let size = g.gen_range(0, 8);
let mut path_buf = RepoPathBuf::new();
for _ in 0..size {
path_buf.push(PathComponentBuf::arbitrary(g).as_ref());
@ -506,7 +506,17 @@ impl quickcheck::Arbitrary for PathComponentBuf {
// string is found. To note that generating Arbitrary Unicode on `char` is implemented
// using a loop where random bytes are validated against the `char` constructor.
loop {
let s = String::arbitrary(g);
let size = g.gen_range(1, 8);
let mut s = String::with_capacity(size);
for _ in 0..size {
let c = loop {
let x = char::arbitrary(g);
if x != SEPARATOR {
break x;
}
};
s.push(c);
}
if let Ok(component) = PathComponentBuf::from_string(s) {
return component;
}