facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 15:27:13 +03:00
Code Issues Projects Releases Wiki Activity

run-tests: unnecessary globs also count as warnings

Browse Source 
When a glob is unnecessary, now there's a diff output and 'run-tests.py -i'
works for accepting the output.
On windows, some tests which have "passed" currently (with some info lines
printed) will now be reported as "warned". (I recommend to recognize "warned"
by buildbot before applying this patch.)
This commit is contained in:
Simon Heimberg 2014-02-13 08:29:44 +01:00
parent 1e51f26c6e
commit b2a439bb78
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/run-tests.py
View File

@ -799,9 +799,8 @@ def tsttest(test, wd, options, replacements, env):
lout = el[:-1] + ' (glob)\n'
r = 0 # warn only
elif r == '-glob':
log('\ninfo, unnecessary glob in %s (after line %d):'
' %s (glob)\n' % (test, pos, el[:-1]))
r = True # pass on unnecessary glob
lout = ''.join(el.rsplit(' (glob)', 1))
r = 0 # warn only
else:
log('\ninfo, unknown linematch result: %r\n' % r)
r = False