mononoke: lfs: Remove throttle limits

Summary:
Now that the new `rate_limiting` crate is being used by LFS server we
can remove the throttle limits code and config.

Differential Revision: D29396505

fbshipit-source-id: 19638bd93ad9dea2638e8501837c6c13e4dd48ff

configerator/structs/scm/mononoke/lfs_server/lfs_server.thrift

@@ -1,4 +1,4 @@
-// @generated SignedSource<<6c4e9dd3ee87785e050f087045b6e918>>
+// @generated SignedSource<<c9b55b978159d626d9fc02e27d8f7790>>
 // DO NOT EDIT THIS FILE MANUALLY!
 // This file is a mechanical copy of the version in the configerator repo. To
 // modify it, edit the copy in the configerator repo instead and copy it over by
@@ -16,28 +16,6 @@ struct ObjectPopularity {
   3: i64 threshold;
 }
 
-// Generic throttle_limits based on ODS counter
-struct ThrottleLimit {
-  // ODS Counter to monitor
-  1: string counter,
-  // Limit to enforce. If the counter exceeds the limit, the client's request
-  // will be rejected.
-  2: i64 limit,
-  // Sleep before returning a rate limiting error (in milliseconds). This is
-  // useful if clients don't do their own backpressure.
-  3: i64 sleep_ms,
-  // A random amount of jitter is added to the above sleep time.
-  // This is the upper limit on that additional sleep time, in milliseconds.
-  4: i64 max_jitter_ms,
-  // Probability of this limit being applied, from 0 (not applied) to 100
-  // (always applied).
-  6: i64 probability_pct,
-  // A list of client identitty sets that the rate limit should be applied to
-  // If client identity set is a superset of one of the sets provided here,
-  // they will be throttled.
-  7: list<list<string>> client_identity_sets,
-}
-
 struct LfsServerConfig {
   // Whether or not to increment counters when sending bytes as opposed to when
   // accepting an upload.
@@ -49,8 +27,7 @@ struct LfsServerConfig {
 
   // Don't use 3 and 4: these were used in the past.
 
-  // Limits to apply
-  5: list<ThrottleLimit> throttle_limits;
+  // 5: deleted
 
   // 6: deleted
 

eden/mononoke/lfs_server/src/config.rs

@@ -134,7 +134,6 @@ impl Default for ServerConfig {
             enable_consistent_routing: false,
             disable_hostname_logging: false,
             enforce_acl_check: false,
-            throttle_limits: vec![],
             loadshedding_limits: vec![],
             object_popularity: None,
             // TODO: Remove those once they're gone from Thrift configs.

eden/mononoke/tests/integration/test-lfs-server-acl-check.t

@@ -20,7 +20,6 @@
   >   "track_bytes_sent": true,
   >   "enable_consistent_routing": false,
   >   "disable_hostname_logging": false,
-  >   "throttle_limits": [],
   >   "enforce_acl_check": false,
   >   "tasks_per_content": 1
   > }

eden/mononoke/tests/integration/test-lfs-server-consistent-hashing.t

@@ -15,7 +15,6 @@
   >   "track_bytes_sent": false,
   >   "enable_consistent_routing": false,
   >   "disable_hostname_logging": false,
-  >   "throttle_limits": [],
   >   "acl_check": false,
   >   "enforce_acl_check": false,
   >   "tasks_per_content": 1

eden/mononoke/tests/integration/test-lfs-server-disabled-hostname-resolution.t

@@ -15,7 +15,6 @@
   >   "track_bytes_sent": true,
   >   "enable_consistent_routing": false,
   >   "disable_hostname_logging": true,
-  >   "throttle_limits": [],
   >   "enforce_acl_check": false,
   >   "tasks_per_content": 1
   > }
@@ -40,7 +39,6 @@
     "object_popularity_category": "",
     "object_popularity_threshold": 0,
     "tasks_per_content": 1,
-    "throttle_limits": [],
     "track_bytes_sent": true
   }
 
@@ -61,7 +59,6 @@
   >   "track_bytes_sent": false,
   >   "enable_consistent_routing": false,
   >   "disable_hostname_logging": false,
-  >   "throttle_limits": [],
   >   "enforce_acl_check": false,
   >   "tasks_per_content": 1
   > }

eden/mononoke/tests/integration/test-lfs-server-live-config.t

@@ -15,7 +15,6 @@
   >   "track_bytes_sent": true,
   >   "enable_consistent_routing": false,
   >   "disable_hostname_logging": false,
-  >   "throttle_limits": [],
   >   "enforce_acl_check": false,
   >   "tasks_per_content": 1
   > }
@@ -39,7 +38,6 @@
     "object_popularity_category": "",
     "object_popularity_threshold": 0,
     "tasks_per_content": 1,
-    "throttle_limits": [],
     "track_bytes_sent": true
   }
 
@@ -49,7 +47,6 @@
   >   "track_bytes_sent": false,
   >   "enable_consistent_routing": false,
   >   "disable_hostname_logging": false,
-  >   "throttle_limits": [],
   >   "enforce_acl_check": false,
   >   "tasks_per_content": 1
   > }
@@ -74,6 +71,5 @@
     "object_popularity_category": "",
     "object_popularity_threshold": 0,
     "tasks_per_content": 1,
-    "throttle_limits": [],
     "track_bytes_sent": false
   }