mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 00:14:35 +03:00
test-check-code: fail new commits which use 'atexit' instead of 'ui.atexit'
Callbacks registered with 'atexit' are sometimes not called (like when hg aborts and calls os._exit). On the other hand, callbacks registered with 'ui.atexit' are called in most cases. Therefore, encouraging the use of 'ui.atexit' by failing the test 'test-check-code.t' appropriately. Test Plan: Ran the test 'test-check-code.t' after importing 'atexit' in one of the py files and confirmed that the test fails. Differential Revision: https://phab.mercurial-scm.org/D961
This commit is contained in:
parent
4d1fce7aa0
commit
bacb1366fc
@ -345,6 +345,7 @@ pypats = [
|
||||
(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
|
||||
(r'\butil\.Abort\b', "directly use error.Abort"),
|
||||
(r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"),
|
||||
(r'^import atexit', "don't use atexit, use ui.atexit"),
|
||||
(r'^import Queue', "don't use Queue, use util.queue + util.empty"),
|
||||
(r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
|
||||
(r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
|
||||
|
Loading…
Reference in New Issue
Block a user