From badd2c8f2603cc850a8fabef0fed6fcbf9bfefa9 Mon Sep 17 00:00:00 2001 From: Alex Eckert Date: Tue, 27 Aug 2019 17:13:56 -0700 Subject: [PATCH] break oss build dependency on fboss/common/ Summary: All of the requisite headers are now open sourced and eden has been converted to use them. This removes any logic that references this directory and kills the now unused cmake file. Reviewed By: chadaustin Differential Revision: D16994732 fbshipit-source-id: 573b8b50540ee64590682be2a54aa94659f12368 --- build/fbcode_builder/manifests/watchman | 1 - common/CMakeLists.txt | 36 ------------------------- 2 files changed, 37 deletions(-) delete mode 100644 common/CMakeLists.txt diff --git a/build/fbcode_builder/manifests/watchman b/build/fbcode_builder/manifests/watchman index 777d08469f..e60dda788c 100644 --- a/build/fbcode_builder/manifests/watchman +++ b/build/fbcode_builder/manifests/watchman @@ -19,7 +19,6 @@ pcre [shipit.pathmap] fbcode/watchman = . -fbcode/fboss/common = common fbcode/eden/fs = eden/fs [shipit.strip] diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt deleted file mode 100644 index b4bae7a02b..0000000000 --- a/common/CMakeLists.txt +++ /dev/null @@ -1,36 +0,0 @@ -add_thrift_cpp2_library( - fb303_thrift_cpp - fb303/if/fb303.thrift - SERVICES - FacebookService -) - -add_library( - common_stats STATIC - stats/ServiceData.cpp -) -set_property( - TARGET common_stats - PROPERTY PUBLIC_HEADER - stats/ExportedHistogramMap.h - stats/ExportedHistogramMapImpl.h - stats/ExportedStatMap.h - stats/ExportedStatMapImpl.h - stats/ExportType.h - stats/DynamicCounters.h - stats/MonotonicCounter.h - stats/ServiceData.h - stats/ThreadCachedServiceData.h - stats/ThreadLocalStats.h -) -target_include_directories( - common_stats - PUBLIC - ${CMAKE_SOURCE_DIR} - ${CMAKE_BINARY_DIR} -) -target_link_libraries( - common_stats - PUBLIC - Folly::folly -)