From c5f328be68aef36e5a640c5c5f6df1a9c785b92c Mon Sep 17 00:00:00 2001 From: Harvey Hunt Date: Wed, 22 Jan 2020 08:16:16 -0800 Subject: [PATCH] hg: Remove purge extension from preimported modules Summary: D19506964 moved the purge extension into core, however purge is still mentioned in dispatch.py's list of external modules to preimport. This causes hg to crash as such: ``` Traceback (most recent call last): File "/data/users/harveyhunt/fbsource/fbcode/buck-out/dev/gen/eden/scm/__hg__/runtime_resources/__default__/eden/scm/hglib/edenscm/__init__.py", line 61, in run dispatch.runchgserver() File "/data/users/harveyhunt/fbsource/fbcode/buck-out/dev/gen/eden/scm/__hg__/runtime_resources/__default__/eden/scm/hglib/edenscm/mercurial/dispatch.py", line 335, in runchgserver _preimportmodules() File "/data/users/harveyhunt/fbsource/fbcode/buck-out/dev/gen/eden/scm/__hg__/runtime_resources/__default__/eden/scm/hglib/edenscm/mercurial/dispatch.py", line 320, in _preimportmodules extensions.preimport(extname) File "/data/users/harveyhunt/fbsource/fbcode/buck-out/dev/gen/eden/scm/__hg__/runtime_resources/__default__/eden/scm/hglib/edenscm/mercurial/extensions.py", line 180, in preimport mod = getattr(__import__("edenscm.hgext.%s" % name).hgext, name) ImportError: No module named purge ``` Remove purge from the extmods list. Reviewed By: ikostia Differential Revision: D19514862 fbshipit-source-id: 6e16ff160f0bc842038b1481bf23aab9c608685d --- eden/scm/edenscm/mercurial/dispatch.py | 1 - 1 file changed, 1 deletion(-) diff --git a/eden/scm/edenscm/mercurial/dispatch.py b/eden/scm/edenscm/mercurial/dispatch.py index eef7a247ad..6b9536e7bc 100644 --- a/eden/scm/edenscm/mercurial/dispatch.py +++ b/eden/scm/edenscm/mercurial/dispatch.py @@ -288,7 +288,6 @@ def _preimportmodules(): "phrevset", "progressfile", "pullcreatemarkers", - "purge", "pushrebase", "rage", "rebase",