facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 06:47:41 +03:00
Code Issues Projects Releases Wiki Activity

delete old overlay doctor check and fix default value for enable-sqlite-overlay in python

Browse Source 
Summary: This rollout has long been finished (the initial rollout from sqlite -> tree). However, I recently renamed tree -> sqlite, which can trigger incorrectly trigger this check since we assume `enable-tree-overlay/enable-sqlite-overlay` is false if its not in the config, but the config is only set to true upon clone. This behavior does not affect the C++ b/c we only write the config during clone.

Reviewed By: xavierd

Differential Revision: D44523497

fbshipit-source-id: ef19af0932fb8f7747bd7b90b8eabe92c1ddc13c
This commit is contained in:
Genevieve (Genna) Helsel 2023-03-29 20:30:02 -07:00 committed by Facebook GitHub Bot
parent a59d20a99a
commit d01d855a74
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
eden/fs/cli/doctor/__init__.py
View File

@ -535,12 +535,6 @@ def check_mount(
debug: bool,
fast: bool,
) -> None:
if sys.platform == "win32":
try:
check_mount_overlay_type(tracker, checkout)
except Exception as ex:
raise RuntimeError("Failed to check overlay type") from ex
if checkout.state is None:
# This checkout is configured but not currently running.
tracker.add_problem(
@ -592,14 +586,6 @@ def check_mount(
raise RuntimeError("Failed to detect nested checkout") from ex
def check_mount_overlay_type(
tracker: ProblemTracker, checkout_info: CheckoutInfo
) -> None:
config = checkout_info.get_checkout().get_config()
if not config.enable_sqlite_overlay:
tracker.add_problem(CheckoutLegacyOverlayType(checkout_info))
def check_running_mount(
tracker: ProblemTracker,
instance: EdenInstance,
@ -711,18 +697,6 @@ on-disk configuration."""
super().__init__(msg, remediation)
class CheckoutLegacyOverlayType(Problem):
def __init__(self, checkout_info: CheckoutInfo) -> None:
msg = f"""\
Your checkout '{checkout_info.path}' is still using the legacy version of
overlay which will be deprecated soon.
"""
remediation = f"""\
Please reclone your repository. You can do so by running `fbclone <repo_type>
{checkout_info.path} --eden --reclone` or do it manually."""
super().__init__(msg, remediation)
class CheckoutNotMounted(FixableProblem):
_out: ui.Output
_instance: EdenInstance