facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 16:31:02 +03:00
Code Issues Projects Releases Wiki Activity

mononoke: avoid duplicates in get_manifests_and_filenodes

Browse Source 
Reviewed By: krallin

Differential Revision: D28249720

fbshipit-source-id: b07cc51afdb174a4ff6f00473cf823a02f4e4d4e
This commit is contained in:
Stanislau Hlebik 2021-05-06 03:30:21 -07:00 committed by Facebook GitHub Bot
parent 37cb232e02
commit d17de2cdb2
1 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
eden/mononoke/repo_client/getbundle_response/src/lib.rs
View File

@ -1165,6 +1165,8 @@ pub fn create_filenodes(
create_filenodes_weighted(ctx, repo, entries).buffered_weight_limited(params)
}
// This function preserves the topological order of entries i.e. filenods or manifest
// created in an earlier commit will be earlier in the output.
pub async fn get_manifests_and_filenodes(
ctx: &CoreContext,
repo: &BlobRepo,
@ -1192,19 +1194,34 @@ pub async fn get_manifests_and_filenodes(
.try_collect()
.await?;
// We avoid duplicate manifests and filenodes, but we preserve the order of the entries
// with respect to the commit i.e. entries from earlier commit are before entries
// from the later commit.
let mut all_mf_entries = vec![];
let mut all_filenode_entries: HashMap<_, Vec<_>> = HashMap::new();
let mut used_mfs = HashSet::new();
let mut ordered_filenode_entries: HashMap<_, Vec<_>> = HashMap::new();
let mut used_filenodes: HashMap<MPath, HashSet<HgFileNodeId>> = HashMap::new();
for (mf_entries, file_entries) in entries {
all_mf_entries.extend(mf_entries);
for (path, mf_id, linknode) in mf_entries {
if used_mfs.insert((path.clone(), mf_id)) {
all_mf_entries.push((path, mf_id, linknode));
}
}
for (file_path, filenodes) in file_entries {
all_filenode_entries
.entry(file_path)
.or_default()
.extend(filenodes);
let used_filenodes = used_filenodes.entry(file_path.clone()).or_default();
let ordered_entries = ordered_filenode_entries.entry(file_path).or_default();
for filenode in filenodes {
if used_filenodes.insert(filenode.filenode) {
ordered_entries.push(filenode);
}
}
}
}
Ok((all_mf_entries, all_filenode_entries))
Ok((all_mf_entries, ordered_filenode_entries))
}
async fn fetch_manifest(