facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 23:07:18 +03:00
Code Issues Projects Releases Wiki Activity

parsers: correctly decref normed value after PyDict_SetItem

Browse Source 
Previously we were leaving this PyObject* with a refcount that was one
too high. Detected with cpychecker.
This commit is contained in:
Augie Fackler 2015-08-18 16:43:26 -04:00
parent b4e44876ff
commit d203bdeed3
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mercurial/parsers.c
View File

@ -253,8 +253,11 @@ static PyObject *make_file_foldmap(PyObject *self, PyObject *args)
if (normed == NULL)
goto quit;
if (PyDict_SetItem(file_foldmap, normed, k) == -1)
if (PyDict_SetItem(file_foldmap, normed, k) == -1) {
Py_DECREF(normed);
goto quit;
}
Py_DECREF(normed);
}
}
return file_foldmap;