facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 08:47:12 +03:00
Code Issues Projects Releases Wiki Activity

tracing-collector: extract logic finding parent span to a function

Browse Source 
Summary: This function will be reused by the next diff.

Reviewed By: DurhamG

Differential Revision: D19782895

fbshipit-source-id: 1e636eabee9b0dffd287a1e6784a24ab2259f51f
This commit is contained in:
Jun Wu 2020-02-28 09:12:39 -08:00 committed by Facebook Github Bot
parent 8b5fdc01fc
commit d205592d42
1 changed files with 28 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
eden/scm/lib/tracing-collector/src/model.rs
View File

@ -1063,6 +1063,33 @@ impl TracingData {
// Keep a stack of TreeSpans to figure out parents.
let mut stack: Vec<TreeSpanId> = vec![0];
// Append a span to the list. Attach it to the "correct" parent span.
let mut append = |tree_span| {
// Find a suitable parent span. Pop parent spans
// if this span does not fit in it.
//
// But, always keep the (dummy) root parent span.
let parent_id = loop {
let parent_id = *stack.last().unwrap();
let parent = &tree_spans[parent_id];
if parent.covers(&tree_span) {
break parent_id;
} else if stack.len() == 1 {
// Use the root span as parent.
break 0;
} else {
stack.pop();
}
};
// Record the new TreeSpan and record parent-child
// relationship.
let id = tree_spans.len();
tree_spans.push(tree_span);
stack.push(id);
tree_spans[parent_id].children.push(id);
};
// Scan through the `Eventus` list. For any `EnterSpan` action, try
// to find the matching `ExitSpan` action and create a span with a
// proper parent.
@ -1100,29 +1127,7 @@ impl TracingData {
}
};
// Find a suitable parent span. Pop parent spans
// if this span does not fit in it.
//
// But, always keep the (dummy) root parent span.
let parent_id = loop {
let parent_id = *stack.last().unwrap();
let parent = &tree_spans[parent_id];
if parent.covers(&tree_span) {
break parent_id;
} else if stack.len() == 1 {
// Use the root span as parent.
break 0;
} else {
stack.pop();
}
};
// Record the new TreeSpan and record parent-child
// relationship.
let id = tree_spans.len();
tree_spans.push(tree_span);
stack.push(id);
tree_spans[parent_id].children.push(id);
append(tree_span);
}
Action::ExitSpan => {
// Handled in EnterSpan. Therefore do nothing here.