facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2025-01-03 02:25:40 +03:00
Code Issues Projects Releases Wiki Activity

github: upgrade from upload-artifact@v3 to v4

Browse Source 
Summary:
The v3 seems to be incompatible with the artifact downloading logic. We got errors like:

  Run actions/download-artifact@v4.1.7
  Downloading single artifact
  Error: Unable to download artifact(s): Artifact not found for name: macos-homebrew-arm64-bottle
         Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
         For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

(from https://github.com/facebook/sapling/actions/runs/12129022616/job/33816893587) for all platforms.

Attempt to fix it by upgrading `upload-artifact` so it becomes "compatible".
See also https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Reviewed By: muirdm

Differential Revision: D66680087

fbshipit-source-id: 3a5de659c7b30dc0215eb3db30f6c5dac8742a6a
This commit is contained in:
Jun Wu 2024-12-02 15:52:18 -08:00 committed by Facebook GitHub Bot
parent b37048eebe
commit d2640f53a6
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/sapling-cli-homebrew-macos-arm64-release.yml vendored
View File

@ -33,7 +33,7 @@ jobs:
- name: Rename bottle to some platform specific name
run: mv sapling*ventura.bottle*.tar.gz sapling_${{ env.SAPLING_VERSION }}.arm64_ventura.bottle.tar.gz
- name: Upload Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: macos-homebrew-arm64-bottle
path: sapling*ventura.bottle*.tar.gz

2
.github/workflows/sapling-cli-homebrew-macos-x86-release.yml vendored
View File

@ -33,7 +33,7 @@ jobs:
- name: Rename bottle to some platform specific name
run: mv sapling*monterey.bottle*.tar.gz sapling_${{ env.SAPLING_VERSION }}.monterey.bottle.tar.gz
- name: Upload Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: macos-homebrew-x86-bottle
path: sapling*monterey.bottle*.tar.gz

2
.github/workflows/sapling-cli-ubuntu-20.04-release.yml vendored
View File

@ -30,7 +30,7 @@ jobs:
working-directory: ./eden/scm
run: ${{ format('mv sapling_{0}_amd64.deb sapling_{0}_amd64.Ubuntu20.04.deb', env.DEB_UPSTREAM_VERSION, env.DEB_UPSTREAM_VERSION) }}
- name: Upload Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ubuntu-20.04
path: ./eden/scm/sapling_*.deb

2
.github/workflows/sapling-cli-ubuntu-22.04-release.yml vendored
View File

@ -30,7 +30,7 @@ jobs:
working-directory: ./eden/scm
run: ${{ format('mv sapling_{0}_amd64.deb sapling_{0}_amd64.Ubuntu22.04.deb', env.DEB_UPSTREAM_VERSION, env.DEB_UPSTREAM_VERSION) }}
- name: Upload Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ubuntu-22.04
path: ./eden/scm/sapling_*.deb

2
.github/workflows/sapling-cli-windows-amd64-release.yml vendored
View File

@ -39,7 +39,7 @@ jobs:
working-directory: ./eden/scm/artifacts
run: ${{ format('Rename-Item sapling_windows_amd64.zip -NewName sapling_windows_{0}_amd64.zip', env.SAPLING_VERSION) }}
- name: Upload Artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: windows-amd64
path: ./eden/scm/artifacts/sapling_windows_*.zip