facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 08:18:15 +03:00
Code Issues Projects Releases Wiki Activity

develwarn: refactor the developer warning logic

Browse Source 
The logic is currently duplicated and we plan to make it a bit smarter. So we
move it into a function first to make the update more robust and simple.
This commit is contained in:
Pierre-Yves David 2015-04-12 14:24:28 -04:00
parent 517621994f
commit d3e735bffe
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mercurial/localrepo.py
View File

@ -926,11 +926,7 @@ class localrepository(object):
or self.ui.configbool('devel', 'check-locks')):
l = self._lockref and self._lockref()
if l is None or not l.held:
msg = 'transaction with no lock\n'
if self.ui.tracebackflag:
util.debugstacktrace(msg, 1)
else:
self.ui.write_err(msg)
scmutil.develwarn(self.ui, 'transaction with no lock\n')
tr = self.currenttransaction()
if tr is not None:
return tr.nest()
@ -1220,11 +1216,7 @@ class localrepository(object):
or self.ui.configbool('devel', 'check-locks')):
l = self._lockref and self._lockref()
if l is not None and l.held:
msg = '"wlock" acquired after "lock"\n'
if self.ui.tracebackflag:
util.debugstacktrace(msg, 1)
else:
self.ui.write_err(msg)
scmutil.develwarn(self.ui, '"wlock" acquired after "lock"\n')
def unlock():
if self.dirstate.pendingparentchange():

7
mercurial/scmutil.py
View File

@ -172,6 +172,13 @@ class casecollisionauditor(object):
self._loweredfiles.add(fl)
self._newfiles.add(f)
def develwarn(tui, msg):
"""issue a developer warning message"""
if tui.tracebackflag:
util.debugstacktrace(msg, 2)
else:
tui.write_err(msg)
def filteredhash(repo, maxrev):
"""build hash of filtered revisions in the current repoview.