facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 00:45:18 +03:00
Code Issues Projects Releases Wiki Activity

hgcommits: use HashMap, not function to provide parents

Browse Source 
Summary:
See the previous diff for context. A concrete HashMap can provide
"hint_pending_subdag". But a parent function cannot.

Reviewed By: sfilipco

Differential Revision: D27629311

fbshipit-source-id: 65168a8d00d9a672396312200016d6749f416d02
This commit is contained in:
Jun Wu 2021-04-13 16:35:05 -07:00 committed by Facebook GitHub Bot
parent 917cf2c9bb
commit d453c93b96
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
eden/scm/lib/hgcommits/src/hgsha1commits.rs
View File

@ -102,17 +102,11 @@ impl AppendCommits for HgCommits {
}
// Write commit graph to DAG.
let commits_map: HashMap<Vertex, HgCommit> = commits
let parents: HashMap<Vertex, Vec<Vertex>> = commits
.iter()
.cloned()
.map(|c| (c.vertex.clone(), c))
.map(|c| (c.vertex, c.parents))
.collect();
let parent_func = move |v: Vertex| -> dag::Result<Vec<Vertex>> {
match commits_map.get(&v) {
Some(commit) => Ok(commit.parents.clone()),
None => v.not_found(),
}
};
let heads: Vec<Vertex> = {
let mut non_heads = HashSet::new();
for commit in commits {
@ -127,9 +121,7 @@ impl AppendCommits for HgCommits {
.cloned()
.collect()
};
let parent_func: Box<dyn Fn(Vertex) -> dag::Result<Vec<Vertex>> + Send + Sync> =
Box::new(parent_func);
self.dag.add_heads(&parent_func, &heads).await?;
self.dag.add_heads(&parents, &heads).await?;
Ok(())
}