facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 00:14:35 +03:00
Code Issues Projects Releases Wiki Activity

log: drop outdated optimization to walk revisions in reverse order

Browse Source 
Since revset is computed lazily, there would be no (or little) benefit to
reverse 'revs' temporarily.
This commit is contained in:
Yuya Nishihara 2016-09-22 20:59:24 +09:00
parent 03a45f600c
commit d5da3be9a3
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mercurial/cmdutil.py
View File

@ -2152,12 +2152,8 @@ def getgraphlogrevs(repo, pats, opts):
if not (revs.isdescending() or revs.istopo()):
revs.sort(reverse=True)
if expr:
# Revset matchers often operate faster on revisions in changelog
# order, because most filters deal with the changelog.
revs.reverse()
matcher = revset.match(repo.ui, expr, order=revset.followorder)
revs = matcher(repo, revs)
revs.reverse()
if limit is not None:
limitedrevs = []
for idx, rev in enumerate(revs):
@ -2182,14 +2178,8 @@ def getlogrevs(repo, pats, opts):
return revset.baseset([]), None, None
expr, filematcher = _makelogrevset(repo, pats, opts, revs)
if expr:
# Revset matchers often operate faster on revisions in changelog
# order, because most filters deal with the changelog.
if not opts.get('rev'):
revs.reverse()
matcher = revset.match(repo.ui, expr, order=revset.followorder)
revs = matcher(repo, revs)
if not opts.get('rev'):
revs.reverse()
if limit is not None:
limitedrevs = []
for idx, r in enumerate(revs):