facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 06:47:41 +03:00
Code Issues Projects Releases Wiki Activity

stack: use useSetRecoilState

Browse Source 
Summary:
Address comments in D45358289. By using `useSetRecoilState` it sounds like it
might avoid re-renders sometimes.

Reviewed By: muirdm

Differential Revision: D45595856

fbshipit-source-id: 74c9f2d42af81736cab564189684717a237875e1
This commit is contained in:
Jun Wu 2023-05-05 14:17:43 -07:00 committed by Facebook GitHub Bot
parent 387d93c2d9
commit d8e1f0027a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
addons/isl/src/CommitTreeList.tsx
View File

@ -37,7 +37,7 @@ import {
import {editingStackHashes, loadingStackState, useStackEditState} from './stackEditState';
import {VSCodeButton} from '@vscode/webview-ui-toolkit/react';
import {ErrorShortMessages} from 'isl-server/src/constants';
import {useRecoilState, useRecoilValue} from 'recoil';
import {useRecoilState, useRecoilValue, useSetRecoilState} from 'recoil';
import {useContextMenu} from 'shared/ContextMenu';
import {Icon} from 'shared/Icon';
import {notEmpty} from 'shared/utils';
@ -320,7 +320,7 @@ function StackActions({tree}: {tree: CommitTreeWithPreviews}): React.ReactElemen
}
function StackEditConfirmButtons(): React.ReactElement {
const [, setStackHashes] = useRecoilState(editingStackHashes);
const setStackHashes = useSetRecoilState(editingStackHashes);
const originalHead = useRecoilValue(latestHeadCommit);
const runOperation = useRunOperation();
const stackEdit = useStackEditState();