facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 06:47:41 +03:00
Code Issues Projects Releases Wiki Activity

config: change nfs.iosize default value

Browse Source 
Summary:
Running the benchmarks/random_writes.cpp benchmark on all power of 2 from 4KiB
to 1MiB shows that 16KiB has the best tradeoff between fast random writes and
fast streaming writes.

Reviewed By: chadaustin

Differential Revision: D44320693

fbshipit-source-id: 2d1839caca3c30acdb6ffc675710a68359d03a76
This commit is contained in:
Xavier Deguillard 2023-03-22 18:48:31 -07:00 committed by Facebook GitHub Bot
parent 2ea5659fdc
commit dfb6efba3c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
eden/fs/config/EdenConfig.h
View File

@ -490,9 +490,13 @@ class EdenConfig : private ConfigSettingManager {
this};
/**
* Buffer size for read and writes requests. Default to 1 MiB.
* Buffer size for read and writes requests. Default to 16 KiB.
*
* 16KiB was determined to offer the best tradeoff of random write speed to
* streaming writes on macOS, use the benchmarks/random_writes.cpp before
* changing this default value.
*/
ConfigSetting<uint32_t> nfsIoSize{"nfs:iosize", 1024 * 1024, this};
ConfigSetting<uint32_t> nfsIoSize{"nfs:iosize", 16 * 1024, this};
/**
* Whether EdenFS NFS sockets should bind themself to unix sockets instead of