logging: remove fastmanifest logging

Summary:
We don't actually use fastmanifest nowadays. Remove logging to reduce noise in
blackbox.

Reviewed By: markbt

Differential Revision: D15710673

fbshipit-source-id: 10d99b4276e76313bf43ffba87e5f2584a67d639

edenscm/hgext/fastmanifest/cachemanager.py

@@ -234,21 +234,13 @@ def cachemanifestfillandtrim(ui, repo, revset):
 
             computedrevs = scmutil.revrange(repo, revset)
             sortedrevs = sorted(computedrevs, key=lambda x: -x)
-            repo.ui.log("fastmanifest", "FM: trying to cache %s\n" % str(sortedrevs))
 
             if len(sortedrevs) == 0:
                 # normally, we prune as we make space for new revisions to add
                 # to the cache.  however, if we're not adding any new elements,
                 # we'll never check the disk cache size.  this is an explicit
                 # check for that particular scenario.
-                before = cache.ondiskcache.items()
                 cache.prune()
-                after = cache.ondiskcache.items()
-                diff = set(after) - set(before)
-                if diff:
-                    ui.log("fastmanifest", "FM: removed entries %s\n" % str(diff))
-                else:
-                    ui.log("fastmanifest", "FM: no entries removed\n")
             else:
                 revstomannodes = {}
                 mannodesprocessed = set()
@@ -262,10 +254,6 @@ def cachemanifestfillandtrim(ui, repo, revset):
                             "[FM] skipped %s, already cached "
                             "(fast path)\n" % (mannode,)
                         )
-                        repo.ui.log(
-                            "fastmanifest",
-                            "FM: skip(rev, man) %s->%s\n" % (rev, mannode),
-                        )
 
                         # Account for the fact that we access this manifest
                         cache.ondiskcache.touch(mannode)
@@ -277,12 +265,7 @@ def cachemanifestfillandtrim(ui, repo, revset):
 
                     try:
                         cache[mannode] = fastmanifest
-                        repo.ui.log(
-                            "fastmanifest",
-                            "FM: cached(rev,man) " "%s->%s\n" % (rev, mannode),
-                        )
                     except CacheFullException:
-                        repo.ui.log("fastmanifest", "FM: overflow\n")
                         break
 
                 # Make the least relevant entries have an artificially older
@@ -340,7 +323,6 @@ class triggers(object):
         result = orig(*args, **kwargs)
 
         for repo in triggers.repos_to_update:
-            repo.ui.log("fastmanifest", "FM: triggering caching for %s\n" % repo.root)
             bg = repo.ui.configbool("fastmanifest", "cacheonchangebackground", True)
 
             if bg:
@@ -356,7 +338,6 @@ class triggers(object):
 
                 cmd.extend(["--repository", repo.root, "cachemanifest"])
 
-                repo.ui.log("fastmanifest", "FM: running command %s\n" % cmd)
                 concurrency.runshellcommand(cmd, silent_worker=silent_worker)
             else:
                 cacher.cachemanifest(repo)
@@ -371,7 +352,6 @@ class triggers(object):
         if ui.configbool("fastmanifest", "cacheonchange", False):
             triggers.repos_to_update.add(repo)
             metricscollector.get().recordsample("trigger", source="bookmark")
-            ui.log("fastmanifest", "FM: caching trigger: bookmark\n")
 
         return orig(self, *args, **kwargs)
 
@@ -383,7 +363,6 @@ class triggers(object):
         if ui.configbool("fastmanifest", "cacheonchange", False):
             triggers.repos_to_update.add(repo)
             metricscollector.get().recordsample("trigger", source="commit")
-            ui.log("fastmanifest", "FM: caching trigger: commit\n")
 
         return orig(self, *args, **kwargs)
 
@@ -394,6 +373,5 @@ class triggers(object):
         if ui.configbool("fastmanifest", "cacheonchange", False):
             triggers.repos_to_update.add(repo)
             metricscollector.get().recordsample("trigger", source="remotenames")
-            ui.log("fastmanifest", "FM: caching trigger: remotenames\n")
 
         return orig(repo, *args, **kwargs)

edenscm/hgext/fastmanifest/metrics.py

@@ -142,10 +142,5 @@ class metricscollector(object):
                         % (kind, sorted(dispkw.items()))
                     )
                 )
-            ui.log(
-                "fastmanifest-%s" % kind,
-                "",  # ui.log requires a format string as args[0].
-                **kwargs
-            )
         if debug:
             ui.status(("[FM-METRICS] End metrics\n"))

tests/test-fb-hgext-fastmanifest-blackbox.t

@@ -1,43 +0,0 @@
-Setup
-
-
-Check diagnosis, debugging information
-1) Setup configuration
-  $ mkcommit() {
-  >    echo "$1" > "$1"
-  >    hg add "$1"
-  >    echo "add $1" > msg
-  >    echo "" >> msg
-  >    hg ci -l msg
-  > }
-
-2) Set up the repo
-
-  $ mkdir cachetesting
-  $ cd cachetesting
-  $ hg init
-  $ cat >> .hg/hgrc << EOF
-  > [extensions]
-  > fastmanifest=
-  > blackbox=
-  > [blackbox]
-  > maxfiles=1
-  > maxsize=5242880
-  > track=fastmanifest
-  > [fastmanifest]
-  > cacheonchange=True
-  > cachecutoffdays=-1
-  > randomorder=False
-  > EOF
-
-  $ mkcommit a
-  $ mkcommit b
-  $ mkcommit c
-  $ mkcommit d
-  $ cat .hg/blackbox.log | grep "FM" | sed "s/.*)>//g" | egrep "(cached|skip)"
-   FM: cached(rev,man) 0->a0c8bcbbb45c63b90b70ad007bf38961f64f2af0
-   FM: cached(rev,man) 1->a539ce0c1a22b0ecf34498f9f5ce8ea56df9ecb7
-   FM: skip(rev, man) 0->a0c8bcbbb45c63b90b70ad007bf38961f64f2af0
-   FM: cached(rev,man) 2->e3738bf5439958f89499a656982023aba57b076e
-   FM: skip(rev, man) 1->a539ce0c1a22b0ecf34498f9f5ce8ea56df9ecb7
-   FM: skip(rev, man) 0->a0c8bcbbb45c63b90b70ad007bf38961f64f2af0