From e347788597bfef5ef932a4d0c41d414a4365088b Mon Sep 17 00:00:00 2001 From: Mads Kiilerich Date: Fri, 27 Jan 2012 03:00:03 +0100 Subject: [PATCH] tests: don't use alias alias doesn't work in Solaris sh. --- contrib/check-code.py | 1 + tests/test-phases-exchange.t | 2 +- tests/test-phases.t | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/contrib/check-code.py b/contrib/check-code.py index cc67419682..3343f8552a 100755 --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -71,6 +71,7 @@ testpats = [ (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), (r'^stop\(\)', "don't use 'stop' as a shell function name"), (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), + (r'^alias\b.*=', "don't use alias, use a function"), ], # warnings [] diff --git a/tests/test-phases-exchange.t b/tests/test-phases-exchange.t index 1319ba7bae..8de721cf11 100644 --- a/tests/test-phases-exchange.t +++ b/tests/test-phases-exchange.t @@ -2,7 +2,7 @@ > [extensions] > graphlog= > EOF - $ alias hgph='hg log -G --template "{rev} {phase} {desc} - {node|short}\n"' + $ hgph() { hg log -G --template "{rev} {phase} {desc} - {node|short}\n" $*; } $ mkcommit() { > echo "$1" > "$1" diff --git a/tests/test-phases.t b/tests/test-phases.t index 3f7727caed..fd3f83d915 100644 --- a/tests/test-phases.t +++ b/tests/test-phases.t @@ -1,4 +1,4 @@ - $ alias hglog='hg log --template "{rev} {phaseidx} {desc}\n"' + $ hglog() { hg log --template "{rev} {phaseidx} {desc}\n" $*; } $ mkcommit() { > echo "$1" > "$1" > hg add "$1"