facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 14:58:03 +03:00
Code Issues Projects Releases Wiki Activity

Respect draft checkbox when confirming ghstack vs sl pr

Browse Source 
Summary:
Small fix, if you submit for the first time in a github repo, it will ask if you want to use ghstack or sl pr. That submit process doesn't respect the draft checkbox you may have selected in the commit info.

I don't think we need to show the draft checkbox _again_ in the interstitial confirmation, since you already selected it before pressing submit, which is the normal condition for using the draft checkbox.

Reviewed By: muirdm

Differential Revision: D44342933

fbshipit-source-id: c720153dd103b98a7936bf3dc3e76ff608007bce
This commit is contained in:
Evan Krause 2023-03-23 22:01:15 -07:00 committed by Facebook GitHub Bot
parent 3d97e1a149
commit e4551d843a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
addons/isl/src/CommitInfo.tsx
View File

@ -540,7 +540,13 @@ function ActionsBar({
// So this one time, we need to manually run the new submit command. // So this one time, we need to manually run the new submit command.
// Future submit calls can delegate to provider.submitOperation(); // Future submit calls can delegate to provider.submitOperation();
runOperation( runOperation(
answer === 'ghstack' ? new GhStackSubmitOperation() : new PrSubmitOperation(), answer === 'ghstack'
? new GhStackSubmitOperation({
draft: shouldSubmitAsDraft,
})
: new PrSubmitOperation({
draft: shouldSubmitAsDraft,
}),
); );
return; return;
} }