From e68cdbba9533772912f4e158b7cf1e82441d0094 Mon Sep 17 00:00:00 2001 From: Jun Wu Date: Wed, 16 Nov 2022 14:06:46 -0800 Subject: [PATCH] log: do not calculate files() if --verbose is not set Summary: Discovered by martinvonz. `sl log` without arguments in a Git repo spends a lot of time on `ctx.files()` but not render them. Update the logic to check the `--verbose` first to avoid slow `.files()` calculation. Reviewed By: bolinfest Differential Revision: D41343821 fbshipit-source-id: c2ad760e2749e1222c6bec7923b62310296d4d56 --- eden/scm/edenscm/cmdutil.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eden/scm/edenscm/cmdutil.py b/eden/scm/edenscm/cmdutil.py index 9e5e1bdc99..c494cc010a 100644 --- a/eden/scm/edenscm/cmdutil.py +++ b/eden/scm/edenscm/cmdutil.py @@ -1992,7 +1992,7 @@ class changeset_printer(object): self.ui.write( columns[key] % " ".join(value), label="ui.debug log.files" ) - elif ctx.files() and self.ui.verbose: + elif self.ui.verbose and ctx.files(): self.ui.write( columns["files"] % " ".join(ctx.files()), label="ui.note log.files" )