facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 16:31:02 +03:00
Code Issues Projects Releases Wiki Activity

eden debug file_stat - add --sizes arg to tool

Browse Source 
Summary:
eden debug file_stat - add --sizes arg to tool
Currently using naive shell call and temprary file to store all of the paths to
get the sizes. This is significantly slower than running without sizes and will
be replaced with proper sizes provided by eden thrif call in the future.

This is sufficient to establish the structure of the output of this command and
start integrating it with sandcastle

Reviewed By: strager

Differential Revision: D16836053

fbshipit-source-id: ad47416a0036d1046768fa9b9b6c9dfefbb8edd4
This commit is contained in:
Wojciech Lis 2019-08-15 19:46:21 -07:00 committed by Facebook Github Bot
parent 2d1616b88b
commit f08c0d4564
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
eden/cli/debug.py
View File

@ -401,9 +401,21 @@ class InodeCmd(Subcmd):
class FileStatsCMD(Subcmd):
def setup_parser(self, parser: argparse.ArgumentParser) -> None:
parser.add_argument("path", help="The path to the eden mount point")
parser.add_argument("--sizes", action="store_true", help="Compute file sizes")
def make_file_entries(
self, base_path: str, paths: List[str], get_sizes: bool
) -> List[Dict[str, Any]]:
if get_sizes:
return [
{"path": path, "size": os.path.getsize(os.path.join(base_path, path))}
for path in paths
]
return [{"path": path} for path in paths]
def run(self, args: argparse.Namespace) -> int:
request_root = args.path
get_sizes = args.sizes
instance, checkout, rel_path = cmd_util.require_checkout(args, request_root)
with instance.get_thrift_client() as client:
@ -412,7 +424,14 @@ class FileStatsCMD(Subcmd):
)
read_files, written_files = split_inodes_by_operation_type(inode_results)
operations = {"read_files": read_files, "written_files": written_files}
operations = {
"read_files": self.make_file_entries(
base_path=request_root, paths=read_files, get_sizes=get_sizes
),
"written_files": self.make_file_entries(
base_path=request_root, paths=written_files, get_sizes=get_sizes
),
}
json.dump(operations, fp=sys.stdout, indent=4, separators=(",", ": "))
return 0