facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 15:27:13 +03:00
Code Issues Projects Releases Wiki Activity

- comment out unused parameters

Browse Source 
Reviewed By: everiq, igorsugak

Differential Revision: D7046710

fbshipit-source-id: 8e10b1f1e2aecebbfb229c742e214db887e5a461
This commit is contained in:
David Lai 2018-02-22 09:37:17 -08:00 committed by Facebook Github Bot
parent 1f21fa3361
commit f2975583d8
4 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
eden/fs/fuse/FuseChannel.cpp
View File

@ -806,7 +806,7 @@ void FuseChannel::finishRequest(const fuse_in_header& header) {
}
folly::Future<folly::Unit> FuseChannel::fuseRead(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto read = reinterpret_cast<const fuse_read_in*>(arg);
@ -820,7 +820,7 @@ folly::Future<folly::Unit> FuseChannel::fuseRead(
}
folly::Future<folly::Unit> FuseChannel::fuseWrite(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto write = reinterpret_cast<const fuse_write_in*>(arg);
auto bufPtr = reinterpret_cast<const char*>(write + 1);
@ -906,7 +906,7 @@ folly::Future<folly::Unit> FuseChannel::fuseSetAttr(
folly::Future<folly::Unit> FuseChannel::fuseReadLink(
const fuse_in_header* header,
const uint8_t* arg) {
const uint8_t* /*arg*/) {
XLOG(DBG7) << "FUSE_READLINK";
return dispatcher_->readlink(header->nodeid).then([](std::string&& str) {
RequestData::get().sendReply(folly::StringPiece(str));
@ -1057,7 +1057,7 @@ folly::Future<folly::Unit> FuseChannel::fuseOpen(
folly::Future<folly::Unit> FuseChannel::fuseStatFs(
const fuse_in_header* header,
const uint8_t* arg) {
const uint8_t* /*arg*/) {
XLOG(DBG7) << "FUSE_STATFS";
return dispatcher_->statfs(header->nodeid)
.then([](struct fuse_kstatfs&& info) {
@ -1068,7 +1068,7 @@ folly::Future<folly::Unit> FuseChannel::fuseStatFs(
}
folly::Future<folly::Unit> FuseChannel::fuseRelease(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto release = reinterpret_cast<const fuse_release_in*>(arg);
XLOG(DBG7) << "FUSE_RELEASE";
@ -1079,7 +1079,7 @@ folly::Future<folly::Unit> FuseChannel::fuseRelease(
folly::Future<folly::Unit> FuseChannel::fuseFsync(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto fsync = reinterpret_cast<const fuse_fsync_in*>(arg);
// There's no symbolic constant for this :-/
@ -1175,7 +1175,7 @@ folly::Future<folly::Unit> FuseChannel::fuseRemoveXAttr(
}
folly::Future<folly::Unit> FuseChannel::fuseFlush(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto flush = reinterpret_cast<const fuse_flush_in*>(arg);
XLOG(DBG7) << "FUSE_FLUSH";
@ -1210,7 +1210,7 @@ folly::Future<folly::Unit> FuseChannel::fuseOpenDir(
}
folly::Future<folly::Unit> FuseChannel::fuseReadDir(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
auto read = reinterpret_cast<const fuse_read_in*>(arg);
XLOG(DBG7) << "FUSE_READDIR";
@ -1223,7 +1223,7 @@ folly::Future<folly::Unit> FuseChannel::fuseReadDir(
}
folly::Future<folly::Unit> FuseChannel::fuseReleaseDir(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto release = reinterpret_cast<const fuse_release_in*>(arg);
XLOG(DBG7) << "FUSE_RELEASEDIR";
@ -1233,7 +1233,7 @@ folly::Future<folly::Unit> FuseChannel::fuseReleaseDir(
}
folly::Future<folly::Unit> FuseChannel::fuseFsyncDir(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto fsync = reinterpret_cast<const fuse_fsync_in*>(arg);
// There's no symbolic constant for this :-/
@ -1310,7 +1310,7 @@ folly::Future<folly::Unit> FuseChannel::fuseBmap(
}
folly::Future<folly::Unit> FuseChannel::fuseBatchForget(
const fuse_in_header* header,
const fuse_in_header* /*header*/,
const uint8_t* arg) {
const auto forgets = reinterpret_cast<const fuse_batch_forget_in*>(arg);
auto item = reinterpret_cast<const fuse_forget_one*>(forgets + 1);

4
eden/fs/inodes/FileInode.cpp
View File

@ -64,7 +64,7 @@ FileInode::State::State(
}
FileInode::State::State(
FileInode* inode,
FileInode* /*inode*/,
mode_t m,
const timespec& creationTime)
: tag(MATERIALIZED_IN_OVERLAY), mode(m) {
@ -188,7 +188,7 @@ FileInode::FileInode(
TreeInodePtr parentInode,
PathComponentPiece name,
mode_t mode,
folly::File&& file,
folly::File&& /*file*/,
timespec ctime)
: InodeBase(ino, mode_to_dtype(mode), std::move(parentInode), name),
state_(folly::in_place, this, mode, ctime) {}

4
eden/fs/inodes/InodeTimestamps.cpp
View File

@ -38,10 +38,10 @@ constexpr int64_t kLargestRepresentableSec = 16299260425ll;
constexpr uint32_t kLargestRepresentableNsec = 709551615u;
struct ClampPolicy {
static uint64_t minimum(timespec ts) {
static uint64_t minimum(timespec /*ts*/) {
return 0;
}
static uint64_t maximum(timespec ts) {
static uint64_t maximum(timespec /*ts*/) {
return ~0ull;
}
};

15
eden/fs/inodes/test/FileHandleMapTest.cpp
View File

@ -35,11 +35,11 @@ class FakeDirHandle : public DirHandle {
const fuse_setattr_in& /* attr */) override {
throw std::runtime_error("fake!");
}
folly::Future<DirList> readdir(DirList&& list, off_t off) override {
folly::Future<DirList> readdir(DirList&& /*list*/, off_t /*off*/) override {
throw std::runtime_error("fake!");
}
folly::Future<folly::Unit> fsyncdir(bool datasync) override {
folly::Future<folly::Unit> fsyncdir(bool /*datasync*/) override {
throw std::runtime_error("fake!");
}
@ -62,19 +62,20 @@ class FakeFileHandle : public FileHandle {
throw std::runtime_error("fake!");
}
folly::Future<BufVec> read(size_t size, off_t off) override {
folly::Future<BufVec> read(size_t /*size*/, off_t /*off*/) override {
throw std::runtime_error("fake!");
}
folly::Future<size_t> write(BufVec&& buf, off_t off) override {
folly::Future<size_t> write(BufVec&& /*buf*/, off_t /*off*/) override {
throw std::runtime_error("fake!");
}
folly::Future<size_t> write(folly::StringPiece data, off_t off) override {
folly::Future<size_t> write(folly::StringPiece /*data*/, off_t /*off*/)
override {
throw std::runtime_error("fake!");
}
folly::Future<folly::Unit> flush(uint64_t lock_owner) override {
folly::Future<folly::Unit> flush(uint64_t /*lock_owner*/) override {
throw std::runtime_error("fake!");
}
folly::Future<folly::Unit> fsync(bool datasync) override {
folly::Future<folly::Unit> fsync(bool /*datasync*/) override {
throw std::runtime_error("fake!");
}