From f3b41ee3a963e631560cb28faf8ef30472516567 Mon Sep 17 00:00:00 2001 From: Stefan Filip Date: Tue, 11 Feb 2020 10:16:11 -0800 Subject: [PATCH] warn: remove large file warning Summary: Not very useful on today's hardware. Reviewed By: quark-zju Differential Revision: D19783741 fbshipit-source-id: d8ff29486cdc5f8e31d929d9fbba827e37012381 --- .../tests/integration/test-large-path-and-content.t | 4 ---- eden/scm/edenscm/mercurial/context.py | 10 ---------- 2 files changed, 14 deletions(-) diff --git a/eden/mononoke/tests/integration/test-large-path-and-content.t b/eden/mononoke/tests/integration/test-large-path-and-content.t index 9949391760..e24cb4353a 100644 --- a/eden/mononoke/tests/integration/test-large-path-and-content.t +++ b/eden/mononoke/tests/integration/test-large-path-and-content.t @@ -32,8 +32,6 @@ setup repo-hg 1+0 records out 157286400 bytes (157 MB* (glob) $ hg add ${LONG_PATH}/${LONG_FILENAME} - this/is/a/very/long/path/that/we/want/to/test/in/order/to/ensure/our/blobimport/as/well/as/mononoke/works/correctly/when/given/such/a/long/path/which/I/hope/will/have/enough/characters/for/the/purpose/of/testing/I/need/few/more/to/go/pass/255/chars/this_is_a_very_long_file_name_that_we_want_to_test_in_order_to_ensure_our_blobimport_as_well_as_mononoke_works_correctly_when_given_such_a_long_path_which_I_hope_will_have_enough_characters_for_the_purpose_of_testing_I_need_few_more_to_go_pass_255_chars: up to 471 MB of RAM may be required to manage this file - (use 'hg revert this/is/a/very/long/path/that/we/want/to/test/in/order/to/ensure/our/blobimport/as/well/as/mononoke/works/correctly/when/given/such/a/long/path/which/I/hope/will/have/enough/characters/for/the/purpose/of/testing/I/need/few/more/to/go/pass/255/chars/this_is_a_very_long_file_name_that_we_want_to_test_in_order_to_ensure_our_blobimport_as_well_as_mononoke_works_correctly_when_given_such_a_long_path_which_I_hope_will_have_enough_characters_for_the_purpose_of_testing_I_need_few_more_to_go_pass_255_chars' to cancel the pending addition) $ hg ci -mlong $ hg log changeset: 0:b8119d283b73 @@ -94,8 +92,6 @@ push one more long path from repo2 1+0 records out 158334976 bytes (158 MB* (glob) $ hg add ${LONG_PATH}2/${LONG_FILENAME}2 - this/is/a/very/long/path/that/we/want/to/test/in/order/to/ensure/our/blobimport/as/well/as/mononoke/works/correctly/when/given/such/a/long/path/which/I/hope/will/have/enough/characters/for/the/purpose/of/testing/I/need/few/more/to/go/pass/255/chars2/this_is_a_very_long_file_name_that_we_want_to_test_in_order_to_ensure_our_blobimport_as_well_as_mononoke_works_correctly_when_given_such_a_long_path_which_I_hope_will_have_enough_characters_for_the_purpose_of_testing_I_need_few_more_to_go_pass_255_chars2: up to 475 MB of RAM may be required to manage this file - (use 'hg revert this/is/a/very/long/path/that/we/want/to/test/in/order/to/ensure/our/blobimport/as/well/as/mononoke/works/correctly/when/given/such/a/long/path/which/I/hope/will/have/enough/characters/for/the/purpose/of/testing/I/need/few/more/to/go/pass/255/chars2/this_is_a_very_long_file_name_that_we_want_to_test_in_order_to_ensure_our_blobimport_as_well_as_mononoke_works_correctly_when_given_such_a_long_path_which_I_hope_will_have_enough_characters_for_the_purpose_of_testing_I_need_few_more_to_go_pass_255_chars2' to cancel the pending addition) $ hg ci -mlong2 $ hg log changeset: 1:8fffbbe6af55 diff --git a/eden/scm/edenscm/mercurial/context.py b/eden/scm/edenscm/mercurial/context.py index 6dc011983b..e3167bcffc 100644 --- a/eden/scm/edenscm/mercurial/context.py +++ b/eden/scm/edenscm/mercurial/context.py @@ -1804,16 +1804,6 @@ class workingctx(committablectx): ui.warn(_("%s does not exist!\n") % uipath(f)) rejected.append(f) continue - if st.st_size > 10000000: - ui.warn( - _( - "%s: up to %d MB of RAM may be required " - "to manage this file\n" - "(use 'hg revert %s' to cancel the " - "pending addition)\n" - ) - % (f, 3 * st.st_size // 1000000, uipath(f)) - ) if not (stat.S_ISREG(st.st_mode) or stat.S_ISLNK(st.st_mode)): ui.warn( _(